Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix case for chpi_info[1] == None #11714

Merged
merged 2 commits into from
Jun 7, 2023
Merged

fix case for chpi_info[1] == None #11714

merged 2 commits into from
Jun 7, 2023

Conversation

agramfort
Copy link
Member

@agramfort agramfort commented May 30, 2023 •
edited by hoechenberger
Loading

closes mne-tools/mne-bids#1141

no clue why this is needed

@larsoner ?

@hoechenberger
Copy link
Member

The issue addressed here is mne-tools/mne-bids#1141

@larsoner
Copy link
Member

From a quick look it's probably because maxwell filtering was applied without movement compensation, or with movement compensation but without adding the CHPI 00XY channels. Change here seems okay to me in principle but will MNE-BIDS do the right thing even with this change? It will report that no HPI coils were active I think

@hoechenberger
Copy link
Member

cc @dnacombo

@dnacombo
Copy link

Indeed, no movement compensation is used in my recordings.

@larsoner larsoner added this to the 1.5 milestone Jun 1, 2023
@larsoner larsoner merged commit d466e18 into mne-tools:main Jun 7, 2023
@larsoner
Copy link
Member

larsoner commented Jun 7, 2023

Let's get the fix in, thanks @agramfort !

@larsoner larsoner deleted the fix_chpi_none branch June 7, 2023 14:04
@larsoner larsoner restored the fix_chpi_none branch June 7, 2023 14:04
larsoner added a commit to larsoner/mne-python that referenced this pull request Jun 23, 2023
@larsoner
Merge remote-tracking branch 'upstream/main' into cola5
24790d4 
* upstream/main: (24 commits)
  Allow int-like as ID of make_fixed_length_events (mne-tools#11748)
  Easycap-M43 montage (mne-tools#11744)
  ENH: Create a Calibrations class for eyetracking data (mne-tools#11719)
  Fix alphabetical order in overview/people.rst, fix sphinx formatting in docstrings and set verbose to keyword-only (mne-tools#11745)
  Add Mathieu Scheltienne to MNE-Python Steering Council (mne-tools#11741)
  removed requirement for curv.*h files to create Brain object (mne-tools#11704)
  [BUG] Fix mne.viz.Brain.add_volume_labels matrix ordering bug (mne-tools#11730)
  Fix installer links (mne-tools#11729)
  MAINT: Update for PyVista deprecation (mne-tools#11727)
  MAINT: Update roadmap (mne-tools#11724)
  MAINT: Update download link [skip azp] [skip cirrus] [skip actions]
  fix case for chpi_info[1] == None (mne-tools#11714)
  Add cmap argument for mne.viz.utils.plot_sensors (mne-tools#11720)
  BUG: Fix one more PySide6 bug (mne-tools#11723)
  MAINT: Fix PySide6 and PyVista compat (mne-tools#11721)
  MRG: If _check_fname() cannot find a file, display the path in quotation marks to help spot accidental trailing spaces (mne-tools#11718)
  Add "array-like" to `_validate_type()` (mne-tools#11713)
  MAINT: Avoid problematic PySide6 (mne-tools#11715)
  Fix installer links (mne-tools#11709)
  Updating change log after PR mne-tools#11575 (mne-tools#11707)
  ...
@hoechenberger hoechenberger mentioned this pull request Jul 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

write_raw_bids() cannot handle MaxFiltered data
4 participants
@agramfort @hoechenberger @larsoner @dnacombo