Merge pull request #845 from mobi/dev

v1.13.2
mobi · Oct 13, 2021 · e9492c2 · e9492c2
2 parents 26e1ba6 + d0d6765
commit e9492c2
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -1,6 +1,6 @@
 # Goponents
 
-###### Currently `v1.13.1`
+###### Currently `v1.13.2`
 
 This project houses a set of UI components for Angular 7+ and designed around the 'Go' design system.
 

diff --git a/projects/go-lib/package.json b/projects/go-lib/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@tangoe/goponents",
-  "version": "1.13.1",
+  "version": "1.13.2",
   "repository": {
     "type": "git",
     "url": "git+https://github.com/mobi/goponents.git"

diff --git a/projects/go-lib/src/lib/components/go-select/go-select.component.html b/projects/go-lib/src/lib/components/go-select/go-select.component.html
@@ -36,13 +36,15 @@
     *ngIf="multiple && items?.length"
     ng-header-tmp>
     <button
+      type="button"
       (click)="onSelectAll()"
       class="go-select__select-all-button"
       [ngClass]="{ 'go-select__select-all-button--dark' : theme === 'dark' }"
       *ngIf="showSelectAll && control.value?.length < items?.length">
       Select All
     </button>
     <button
+      type="button"
       (click)="onRemoveAll()"
       class="go-select__select-all-button"
       [ngClass]="{ 'go-select__select-all-button--dark' : theme === 'dark' }"

diff --git a/projects/go-lib/src/lib/services/form.service.ts b/projects/go-lib/src/lib/services/form.service.ts
@@ -11,13 +11,14 @@ export class GoFormService {
    * Each method returns a string generated by args passed by the Validator.
    */
   ngValidators: { [k: string]: (...args: any) => string } = {
-    email: (obj: ValidationErrors): string => !obj.email ? `Must be a valid email adress.` : '',
+    email: (obj: ValidationErrors): string => !obj.email ? `Must be a valid email address.` : '',
     max: (obj: ValidationErrors): string => `Must be less than ${obj.max}, entered ${obj.actual}`,
     maxlength: (obj: ValidationErrors): string => `Must not exceed ${obj.requiredLength} characters, entered ${obj.actualLength}`,
     min: (obj: ValidationErrors): string => `Must be greater than ${obj.min}, entered ${obj.actual}`,
     minlength: (obj: ValidationErrors): string => `Must contain at least ${obj.requiredLength} characters, entered ${obj.actualLength}`,
-    required: (): string => 'Required',
-    requiredtrue: (): string => 'Required'
+    required: (): string => 'This is a required field',
+    requiredtrue: (): string => 'This is a required field',
+    pattern: () => 'Invalid Input'
   };
 
   /**