Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.12.0 #826

Merged
merged 27 commits into from
Aug 20, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
c68a5c3
added remove all on select
priyankafnu Aug 4, 2021
97b708c
test case for remove all
priyankafnu Aug 11, 2021
67aefd5
exception update
priyankafnu Aug 11, 2021
503f060
Feature: Table Generic Typing
grahamhency Aug 12, 2021
dbf7911
Add maxHeight feature and override binding
grahamhency Aug 12, 2021
4c91553
Add ability to pass in an icon to toasts
grahamhency Aug 12, 2021
15b1414
Bug go-side-nav Active Indicator
grahamhency Aug 13, 2021
b01b842
Fix html formatting
grahamhency Aug 13, 2021
6c7ea4e
Extract toast padding to a variable
grahamhency Aug 13, 2021
11ec4db
Update tests for side nav menu
grahamhency Aug 13, 2021
0de618a
Merge pull request #818 from mobi/feature_table_generic_typing
grahamhency Aug 13, 2021
1c06a52
Chore Form Toggles Borders & Box Shadows
grahamhency Aug 13, 2021
fd771f3
Change back to only showing root indicator
grahamhency Aug 13, 2021
2bf2083
Chore go-button Secondary Colors
grahamhency Aug 13, 2021
e0462e7
Merge pull request #822 from mobi/chore_button_secondary_colors
grahamhency Aug 13, 2021
7edf02a
Merge pull request #819 from mobi/feature_toast_maxheight_icon_override
grahamhency Aug 13, 2021
53a0ba1
changes done
priyankafnu Aug 16, 2021
47cd727
spec changes
priyankafnu Aug 16, 2021
0d93abf
condition changed
priyankafnu Aug 17, 2021
497b7f1
Merge pull request #816 from mobi/feature/remove-all-TME-257
grahamhency Aug 18, 2021
2e56b13
Merge pull request #823 from mobi/chore_form_toggles_borders
grahamhency Aug 18, 2021
1492e8c
Merge pull request #821 from mobi/bug_sidenav_active_indicator
grahamhency Aug 18, 2021
8525af8
Feature go-table wrapContent
grahamhency Aug 12, 2021
e4afdcd
Merge pull request #820 from mobi/feature_table_wrapContent
grahamhency Aug 20, 2021
448dd0c
[Chore] Panel Disable Option (#824)
jiaweicai92 Aug 20, 2021
c33faaf
Chore v1.12.0 Documentation Update
grahamhency Aug 20, 2021
9de4c0d
Merge pull request #825 from mobi/chore_1.12.0_docs_update
grahamhency Aug 20, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
111 changes: 63 additions & 48 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,22 +1,27 @@
# Goponents

###### Currently `v1.11.0`
###### Currently `v1.12.0`

This project houses a set of UI components for Angular 7+ and designed around the 'Go' design system.

# Getting Started

1. Take a look at our [code of conduct](https://github.com/mobi/goponents/blob/master/CODE_OF_CONDUCT.md)
2. Read through our [contribution guidelines](https://github.com/mobi/goponents/blob/master/CONTRIBUTING.md)
3. Install the latest version of npm

```bash
npm install -g npm@latest
```

or if you are using `nvm` you can alternatively run:

```bash
nvm install-latest-npm
```

_We try to stay as up to date a possible._

4. Install all of the node modules
```bash
npm install
Expand All @@ -38,46 +43,54 @@ This project houses a set of UI components for Angular 7+ and designed around th
_Test will continue to run anytime a file is saved. This will help ensure that breaking changes aren't introduced when changes are introduced._

# Directory structure

The project is separated up into four project directories.

### go-lib

[projects/go-lib](https://github.com/mobi/goponents/tree/master/projects/go-lib) is where all of our production components, services, and other items are built out. If you are adding that you would like to distribute, this is where you will do that work.

The components are located [here](https://github.com/mobi/goponents/tree/master/projects/go-lib/src/lib/components):

```bash
projects/go-lib/src/lib/components
```

The styles are located [here](https://github.com/mobi/goponents/tree/master/projects/go-lib/src/lib/styles):

```bash
projects/go-lib/src/lib/styles
```

You can build this project by running `npm run build_lib`

### go-style-guide

[projects/go-style-guide](https://github.com/mobi/goponents/tree/master/projects/go-style-guide) is separate app contains all of the documentation for the styles and usage of all the components and available styles in the `go-lib` project.

The base style guide app is located [here](https://github.com/mobi/goponents/tree/master/projects/go-style-guide/src/app);

```bash
projects/go-style-guide/src/app
```

You can start this project by running `npm run style_guide`

### go-tester

[projects/go-tester](https://github.com/mobi/goponents/tree/master/projects/go-tester) is separate app that allows us to test the implementation of our components as we build them out. If you want to test to make sure your go-lib components work as expected in a more real world setting, this is where you will do that work.

The base tester app is located [here](https://github.com/mobi/goponents/tree/master/projects/go-tester/src/app);

```bash
projects/go-tester/src/app
```

You can start this project by running `npm run tester`

### go-tester-e2e
[projects/go-tester-e2e](https://github.com/mobi/goponents/tree/master/projects/go-tester-e2e) will eventually be where we will write all of our end to end testing for our go-tester app. We have not yet done this, but we would welcome any [contributions](https://github.com/mobi/goponents/blob/master/CONTRIBUTING.md).

[projects/go-tester-e2e](https://github.com/mobi/goponents/tree/master/projects/go-tester-e2e) will eventually be where we will write all of our end to end testing for our go-tester app. We have not yet done this, but we would welcome any [contributions](https://github.com/mobi/goponents/blob/master/CONTRIBUTING.md).

# Other Useful Things

Expand All @@ -86,12 +99,15 @@ You can start this project by running `npm run tester`
Run `ng generate lib/components/component-name` to generate a new component. You can also use `ng generate directive|pipe|service|class|guard|interface|enum|module`.

### Publishing to npm

To build and pack the library **locally** run:

```
npm run package
```

To build and pack the library locally and publish that package to npm run:

```
npm run publish
```
Expand All @@ -106,49 +122,48 @@ To do this properly, you must export each individual file within the `public_api

### Components Available

| Component | Notes |
|----------------|----------------------------------------|
| accordion | Available |
| action sheet | Available |
| app drawer | Available |
| badge | Available |
| button | Available |
| button group | Available |
| card | Available |
| checkbox | Available |
| checkbox group | Available |
| copy button | Available |
| copy docs link | Available |
| datepicker | Available |
| file upload | Available |
| footer | Available |
| header | Available |
| header bar | Available |
| hint | Available |
| icon | Available |
| icon button | Available |
| input | Available |
| layout | Available |
| loader | Available |
| modal | Available |
| off-canvas | Available |
| pill | Available |
| portal | Available |
| radio | Available |
| radio group | Available |
| select | Available |
| search | Available |
| side nav | Available |
| switch toggle | Available |
| table | Available |
| tabs | Available |
| timepicker | Available |
| textarea | Available |
| toaster | Available |
| toasts | Available |
| tree | Available |
| virtual scroll | Available via Material CDK |
| wysiwyg | Available via TinyMCE |
|----------------|----------------------------------------|
| tooltip | Idea |

| Component | Notes |
| ---------------- | ---------------------------------------- |
| accordion | Available |
| action sheet | Available |
| app drawer | Available |
| badge | Available |
| button | Available |
| button group | Available |
| card | Available |
| checkbox | Available |
| checkbox group | Available |
| copy button | Available |
| copy docs link | Available |
| datepicker | Available |
| file upload | Available |
| footer | Available |
| header | Available |
| header bar | Available |
| hint | Available |
| icon | Available |
| icon button | Available |
| input | Available |
| layout | Available |
| loader | Available |
| modal | Available |
| off-canvas | Available |
| pill | Available |
| portal | Available |
| radio | Available |
| radio group | Available |
| select | Available |
| search | Available |
| side nav | Available |
| switch toggle | Available |
| table | Available |
| tabs | Available |
| timepicker | Available |
| textarea | Available |
| toaster | Available |
| toasts | Available |
| tree | Available |
| virtual scroll | Available via Material CDK |
| wysiwyg | Available via TinyMCE |
| ---------------- | ---------------------------------------- |
| tooltip | Idea |
2 changes: 1 addition & 1 deletion projects/go-lib/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@tangoe/goponents",
"version": "1.11.0",
"version": "1.12.0",
"repository": {
"type": "git",
"url": "git+https://github.com/mobi/goponents.git"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
<ng-template #noLink>
<button
class="go-panel"
[disabled]="disablePanel"
[ngClass]="panelClasses()"
(click)="handleAction()">
<span class="go-panel__title">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
@import '../../../../../styles/mixins';

$base-medium: #767676 !default;
$theme-light-transparentized: rgba($theme-light-color, .5);

.go-panel {
@include transition;
Expand Down Expand Up @@ -72,6 +73,11 @@ $base-medium: #767676 !default;
&--header {
color: $base-medium;
}

&--disabled {
color: $theme-light-transparentized;
pointer-events: none;
}
}

.go-action-sheet {
Expand Down Expand Up @@ -116,4 +122,8 @@ button {
&:focus {
outline: none;
}

&:disabled {
color: $theme-light-transparentized;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export class GoPanelComponent {
@Input() panelContent: string;
@Input() target: string;
@Input() closeOnClick: boolean = true;
@Input() disablePanel: boolean = false;

@Output() action: EventEmitter<void> = new EventEmitter<void>();

Expand All @@ -23,7 +24,8 @@ export class GoPanelComponent {
panelClasses(): object {
return {
'go-panel--danger': this.danger,
'go-panel--header': this.showHeader
'go-panel--header': this.showHeader,
'go-panel--disabled': this.disablePanel
};
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
@import '../../../../styles/mixins';

$transparent-color: rgba(0, 0, 0, 0);
$button-shadow-secondary: 0 0 0 3px transparentize($base-light-tertiary, .75);
$button-shadow-secondary-hover: 0 0 0 3px transparentize($theme-light-bg-hover, .5);
$button-shadow-secondary-active: 0 0 0 3px transparentize($theme-light-bg-hover, .5);

@mixin disabled-states($bg, $color, $color-opacity: .7) {
// scss-lint:disable VariableForProperty
Expand Down Expand Up @@ -119,13 +120,15 @@ $button-shadow-secondary: 0 0 0 3px transparentize($base-light-tertiary, .75);
}

&--secondary {
border: 1px solid lighten($base-light-secondary, 10%);
border: 1px solid $base-light-tertiary;

&:hover {
box-shadow: $button-shadow-secondary-hover;
}

&:hover,
&:focus,
&:active {
border: 1px solid lighten($base-light-secondary, 10%);
box-shadow: $button-shadow-secondary;
box-shadow: $button-shadow-secondary-active;
}

&.go-button-group {
Expand Down Expand Up @@ -160,12 +163,12 @@ $button-shadow-secondary: 0 0 0 3px transparentize($base-light-tertiary, .75);
&:hover,
&:focus {
background: $theme-light-bg-hover;
border: 1px solid $theme-light-bg-hover;
border: 1px solid $base-light-tertiary;
}

&:active {
background: $theme-light-bg-active;
border: 1px solid $theme-light-bg-active;
border: 1px solid $base-light-tertiary;
}

&:disabled:not(.go-button--loading) {
Expand Down Expand Up @@ -421,21 +424,21 @@ $button-shadow-secondary: 0 0 0 3px transparentize($base-light-tertiary, .75);

&--secondary {
background: $theme-light-bg-hover;
border: 1px solid lighten($base-light-secondary, 10%);
border: 1px solid $base-light-tertiary;
border-left: 0;
color: $theme-light-color;

&:hover,
&:focus {
background: $theme-light-bg-active;
border-left: 0;
box-shadow: $button-shadow-secondary;
box-shadow: $button-shadow-secondary-hover;
}

&:active {
background: darken($theme-light-bg, 10%);
border-left: 0;
box-shadow: $button-shadow-secondary;
box-shadow: $button-shadow-secondary-active;
}

&:disabled:not(.go-button--loading) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

&:enabled:hover + .go-radio {
&__custom-radio {
box-shadow: 0 0 2px 1.5px lighten($base-light-secondary, 13.5%);
box-shadow: $form-shadow-hover;
}
}

Expand All @@ -19,7 +19,7 @@

&:enabled:checked:hover + .go-radio {
&__custom-radio {
box-shadow: 0 0 2px 1.5px $ui-color-primary-hover;
box-shadow: $form-shadow-active;
}
}

Expand All @@ -35,11 +35,17 @@
border: 4px solid lighten($base-light-secondary, 13.5%);
}
}

&:disabled:hover + .go-radio {
&__custom-radio {
box-shadow: none;
}
}
}

&__custom-radio {
background-color: $base-light;
border: 1px solid lighten($base-light-secondary, 13.5%);
border: 1px solid $base-light-tertiary;
border-radius: 100%;
cursor: pointer;
display: inline-block;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,16 @@
</button>
</ng-template>
</ng-container>
<ng-container *ngIf="multiple && items?.length && control.value">
<ng-template ng-header-tmp>
<button
(click)="onRemoveAll()"
class="go-select__select-all-button"
[ngClass]="{ 'go-select__select-all-button--dark' : theme === 'dark' }">
Remove All
</button>
</ng-template>
</ng-container>
<ng-container *ngIf="goSelectSelectedOption">
<ng-template ng-label-tmp let-item="item">
<ng-container *ngTemplateOutlet="goSelectSelectedOption; context: { $implicit: item }"></ng-container>
Expand Down
Loading