Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cd workflow fixes #861

Merged
merged 3 commits into from
Dec 7, 2021
Merged

Cd workflow fixes #861

merged 3 commits into from
Dec 7, 2021

Conversation

grahamhency
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
    Tests for the changes have been added
    Docs have been added or updated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Style Update (CSS)
  • Other... Please describe:

What is the current behavior?

  • Release generated is not using main as the target
  • Publishing to npm fails

What is the new behavior?

Fixes both of the above.

Does this PR introduce a breaking change?

  • Yes
  • No

@grahamhency grahamhency merged commit 074a1c2 into dev Dec 7, 2021
@grahamhency grahamhency deleted the cd_workflow_fixes branch December 7, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant