Changes_GOP-877,GOP-876,GOP-847-BUG-minimum_height_for_textarea #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed GOP-876 uniform card margins, GOP-877 set minimum_height_for_textarea and GOP-847 file uploading component bug fix.
adhiyan-tangoe
added
bug
adhiyan-tangoe
changed the title
jiaweicai92
requested changes
Sep 29, 2022
|
@kpmurphh and myself have no way to provide approval/feedback for this issue. We do not have an instance of goponents on our systems in order to look at the visual fix and we are not in a position to give feedback on coding approaches. Please attach a screenshot of the update or block time on one of our calendars for a review session. |
Saravanan-Tangoe
dismissed stale reviews from jiaweicai92 and swimtech20
The base branch was changed.
swimtech20
reviewed
Mar 30, 2023
stolve
previously approved these changes
Mar 31, 2023
swimtech20
previously approved these changes
Mar 31, 2023
swimtech20
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed GOP-876 uniform card margins, GOP-877 set minimum_height_for_textarea and GOP-847 file uploading component bug fix.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Resolves
#877
#876
#847
What is the new behavior?
#877 - Textarea will have the minimum width as 70px.
#876 - Last child of the card content will have no margin bottom.
#847 - Reselecting the same file after clearing is working fine.
Does this PR introduce a breaking change?