Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Progress Bar #892

Merged
merged 12 commits into from
Mar 30, 2023
Merged

[Feature] Progress Bar #892

merged 12 commits into from
Mar 30, 2023

Conversation

Saravanan-Tangoe
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added
  • Docs have been added or updated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Style Update (CSS)
  • Other... Please describe:

What is the current behavior?

Resolves 814

What is the new behavior?

building new progress bar

Does this PR introduce a breaking change?

  • Yes
  • No

@Saravanan-Tangoe Saravanan-Tangoe added the feature New feature request label Oct 13, 2022
@Saravanan-Tangoe Saravanan-Tangoe changed the title [Feature] Progress Bar #814 [Feature] Progress Bar Oct 13, 2022
swimtech20
swimtech20 reviewed Oct 13, 2022
View reviewed changes
Copy link
Collaborator

@swimtech20 swimtech20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One super quick change, but it looks good!

projects/go-lib/src/public_api.ts Outdated Show resolved Hide resolved
jaykravetz
jaykravetz previously approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@jaykravetz jaykravetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

swimtech20
swimtech20 previously approved these changes Oct 28, 2022
View reviewed changes
@Saravanan-Tangoe Saravanan-Tangoe self-assigned this Jan 30, 2023
@RonMichaud RonMichaud merged commit bb0ec2d into dev Mar 30, 2023
@RonMichaud RonMichaud deleted the Feature#814 branch March 30, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swimtech20 swimtech20 swimtech20 approved these changes

@jiaweicai92 jiaweicai92 Awaiting requested review from jiaweicai92

@kpmurphh kpmurphh Awaiting requested review from kpmurphh

@stolve stolve Awaiting requested review from stolve

@jaykravetz jaykravetz Awaiting requested review from jaykravetz

Assignees

@Saravanan-Tangoe Saravanan-Tangoe

Labels
feature New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Progress Bar
4 participants
@Saravanan-Tangoe @jaykravetz @swimtech20 @RonMichaud