[BUGFIX] - Fix for duplicate modal and offcanvas content 894 #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saravanan-Tangoe
changed the title
jiaweicai92
previously approved these changes
Oct 19, 2022
projects/go-lib/src/lib/components/go-off-canvas/go-off-canvas.component.ts
Outdated
Show resolved
Hide resolved
adhiyan-tangoe
previously approved these changes
Oct 19, 2022
jaykravetz
dismissed stale reviews from jiaweicai92 and adhiyan-tangoe
via
c9ac9d2
jaykravetz
force-pushed
the
goModalDuplicateContent#894
branch
from
8b7c8f1
to
c9ac9d2
Compare
|
@jaykravetz can you please confirm the reason for dismiss stale review? |
RonMichaud
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
go-modal and go-off-canvas keeps adding duplicates body contents when user hits enter key
To reproduce:
https://tangoe.design/ui-kit/off-canvas
https://tangoe.design/ui-kit/modal
Resolves 894
What is the new behavior?
Should not create duplicate contents
Does this PR introduce a breaking change?