Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.16.0 #916

Merged
merged 51 commits into from
Jun 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
3818c4c
Update go-button.component.scss
sudheepdivakargithub Jan 10, 2022
e5a6c86
GOP-877-BUG-minimum_height_for_textarea
adhiyan-tangoe Sep 26, 2022
5a0ea82
Changes_bugfix_chore_task
Saravanan-Tangoe Sep 27, 2022
87e2a91
alignment corrected for icon button
Pooja-kj Sep 27, 2022
3ff676e
codeclimate issue fix
Saravanan-Tangoe Sep 28, 2022
c674cb9
Codeclimate fix
Saravanan-Tangoe Sep 28, 2022
06a4590
remove extra padding
Saravanan-Tangoe Sep 29, 2022
804d8b2
Initial components and module interaction
Saravanan-Tangoe Sep 29, 2022
f0d8c63
Accordion_style changes
Pooja-kj Sep 29, 2022
f64da80
Changed dark theme
Pooja-kj Oct 10, 2022
6fadeaa
Changes [CHORE] 868 max height for toast
adhiyan-tangoe Oct 11, 2022
e0727fd
Changes [CHORE] 767 action sheet design changes #767
adhiyan-tangoe Oct 11, 2022
65db85c
Update _forms.scss
adhiyan-tangoe Oct 11, 2022
686514e
Changes [CHORE] 767 action sheet design changes #891
adhiyan-tangoe Oct 12, 2022
7b8840d
Determinate and indeterminate progress bar
Saravanan-Tangoe Oct 12, 2022
7ef4277
style update
Saravanan-Tangoe Oct 12, 2022
05c0fb6
Changes [CHORE] 868 max height for toast #890
adhiyan-tangoe Oct 12, 2022
9ceecb8
UT
Saravanan-Tangoe Oct 13, 2022
ccabfd8
safari styling fix
Saravanan-Tangoe Oct 13, 2022
45489e9
Fixing code climate issues
Saravanan-Tangoe Oct 13, 2022
5505e72
Changes [CHORE] 868 max height for toast #890
adhiyan-tangoe Oct 13, 2022
4af91fe
Changes [CHORE] 767 action sheet design changes #891
adhiyan-tangoe Oct 13, 2022
e8d351c
comment line message
Saravanan-Tangoe Oct 14, 2022
b6b6b7c
clear code climate issues
Saravanan-Tangoe Oct 17, 2022
94ddbd9
code climate fix
Saravanan-Tangoe Oct 17, 2022
f1ec6f8
dark theme color changes done
Pooja-kj Oct 18, 2022
1876c37
issue fixed
Pooja-kj Oct 19, 2022
c68904b
removed white spaces
Pooja-kj Oct 19, 2022
125aea2
BUGFIX_TIME_PICKER_ALIGNMENT-CHORE_BACKGROUND_COLOR_CHANGE
Vijeta7 Oct 19, 2022
4ceed6e
ALIGNMENT AND NAMING CHANGES
Vijeta7 Oct 19, 2022
9cbced4
Fix for duplicate modal and offcanvas content
Saravanan-Tangoe Oct 19, 2022
4c80153
ALIGNMENT_CHANGES
Vijeta7 Oct 19, 2022
c9ac9d2
removing whitespace
Saravanan-Tangoe Oct 19, 2022
f325ee2
Re-run Checks
Mar 23, 2023
494ef96
Re-run Checks
Mar 23, 2023
f4f824d
Merge branch 'dev' of https://github.com/mobi/goponents into Feature#814
Saravanan-Tangoe Mar 24, 2023
7386ce9
Increasing test coverage
Saravanan-Tangoe Mar 24, 2023
445e1c7
Update github src
Saravanan-Tangoe Mar 24, 2023
8b46a61
Merge pull request #896 from mobi/goModalDuplicateContent#894
RonMichaud Mar 30, 2023
4fa20a2
Merge pull request #887 from mobi/CardSpaceReduce#786
RonMichaud Mar 30, 2023
5729507
Merge pull request #865 from mobi/SplitButton#848
RonMichaud Mar 30, 2023
bb0ec2d
Merge pull request #892 from mobi/Feature#814
RonMichaud Mar 30, 2023
c8f8712
Merge pull request #895 from mobi/BUGFIX_TIME_PICKER_ALIGNMENT-CHORE_…
RonMichaud Mar 30, 2023
6cfe8df
Merge pull request #891 from mobi/GOP-767-CHORE-action_sheet_design_c…
RonMichaud Mar 30, 2023
0a815e8
Merge pull request #890 from mobi/GOP-868-CHORE-max_height_for_toast
RonMichaud Mar 30, 2023
b5a7a42
Merge pull request #888 from mobi/884-Accordion_Styling(Normal&Dark-t…
RonMichaud Mar 30, 2023
f201378
Merge pull request #883 from mobi/BUGFIX-872_and_CHORE-869-870
RonMichaud Mar 30, 2023
db1b2c5
GOP-807 empty checkin to trigger build
swimtech20 Apr 5, 2023
50bb3a2
Merge pull request #880 from mobi/GOP-877-BUG-minimum_height_for_text…
swimtech20 Apr 5, 2023
2b62a50
Fix select all filtered list (#914)
Jun 7, 2023
2bcf768
v1.16.0 (#915)
swimtech20 Jun 7, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/go-lib/karma.conf.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ module.exports = function (config) {
thresholds: {
statements: 93,
lines: 92,
branches: 79,
branches: 75,
functions: 88,
},
},
Expand Down
2 changes: 1 addition & 1 deletion projects/go-lib/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@tangoe/goponents",
"version": "1.15.1",
"version": "1.16.0",
"repository": {
"type": "git",
"url": "git+https://github.com/mobi/goponents.git"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@

cursor: pointer;
display: flex;
font-size: 1.2rem;
font-size: 1.125rem;
padding: 1.2rem 1rem;
position: relative;

Expand All @@ -76,10 +76,10 @@
}

&--dark {
background-color: darken($base-dark-secondary, 7%);
background-color: $base-dark;

&:hover {
background-color: darken($base-dark-secondary, 3.5%);
background-color: darken($base-dark, 3.5%);
}
}

Expand All @@ -88,13 +88,17 @@

// scss-lint:disable SelectorFormat
&.go-accordion-panel__header--dark {
background-color: darken($base-dark-secondary, 3.5%);
}

&.go-accordion-panel__header--dark:hover {
background-color: darken($base-dark-secondary, 7%);
}
}

&--slim {
font-size: 1rem;
padding: 1rem;
font-size: 0.875rem;
padding: 0.625rem 1rem;
}
}

Expand Down Expand Up @@ -132,9 +136,11 @@
}

&__content {
padding: 1.5rem 1rem;
font-size: 0.875rem;
padding: 1rem;

&--slim {
font-size: 0.875rem;
padding: 1rem;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ $as-before-box-diag-width: 21.21px;
position: relative;

&__scroll-container {
max-height: 375px;
overflow: auto;
overflow: hidden;
}

&__content {
border-radius: $global-radius;
overflow: hidden;
max-height: 375px;
overflow: auto;
}

&__content-container {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,8 @@ $theme-light-transparentized: rgba($theme-light-color, .5);
color: $ui-color-negative;
}

.go-panel {
&__title {
& &-text {
color: $ui-color-negative;
}
}
.go-panel__title-text {
color: $ui-color-negative;
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,42 @@ describe('GoBadgeComponent', () => {
it('should create', () => {
expect(component).toBeTruthy();
});

describe("badgeClasses()", () => {
beforeEach(() => {
component.badgeStyles = {};
});

it("returns an object that sets go-badge--positive to true based on type", () => {
expect(component.badgeStyles["go-badge--positive"]).toBeFalsy();

component.badgeColor = "positive";
component.ngOnChanges();
expect(component.badgeStyles["go-badge--positive"]).toBe(true);
});

it("returns an object that set go-badge--negative to true based on type", () => {
expect(component.badgeStyles["go-badge--negative"]).toBeFalsy();

component.badgeColor = "negative";
component.ngOnChanges();
expect(component.badgeStyles["go-badge--negative"]).toBe(true);
});

it("returns an object that set go-badge--neutral to true based on type", () => {
expect(component.badgeStyles["go-badge--neutral"]).toBeFalsy();

component.badgeColor = "neutral";
component.ngOnChanges();
expect(component.badgeStyles["go-badge--neutral"]).toBe(true);
});

it("returns an object that set go-badge--dot to true based on type", () => {
expect(component.badgeStyles["go-badge--dot"]).toBeFalsy();

component.displayData = false;
component.ngOnChanges();
expect(component.badgeStyles["go-badge--dot"]).toBe(true);
});
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ $button-shadow-secondary-active: 0 0 0 3px transparentize($theme-light-bg-hover,
}

&--icon-only {
padding: calc(.625rem - 2px) .625rem;
padding: calc(.625rem - 2px) 1rem;
}

&__icon ~ &__text:not(:empty) {
Expand Down Expand Up @@ -142,22 +142,21 @@ $button-shadow-secondary-active: 0 0 0 3px transparentize($theme-light-bg-hover,
}

&:disabled:not(.go-button--loading) {
border: 1px solid $theme-light-bg-active;
@include disabled-states($theme-light-bg-active, 'dark');
border: 1px solid $base-light-tertiary;

&:hover,
&:focus {
border: 1px solid $theme-light-bg-active;
@include disabled-states($theme-light-bg-active, 'dark');
border: 1px solid $base-light-tertiary;
box-shadow: none;
}
}
}

&--tertiary {
border: 1px solid $theme-light-bg;
}

&--secondary,
&--tertiary {
background: $theme-light-bg;
border: 1px solid $theme-light-bg;
color: $theme-light-color;

&:hover,
Expand Down Expand Up @@ -442,13 +441,13 @@ $button-shadow-secondary-active: 0 0 0 3px transparentize($theme-light-bg-hover,
}

&:disabled:not(.go-button--loading) {
border: 1px solid $theme-light-bg-active;
border: 1px solid $base-light-tertiary;
border-left: 0;

&:hover,
&:focus {
background: $theme-light-bg-hover;
border: 1px solid $theme-light-bg-active;
border: 1px solid $base-light-tertiary;
border-left: 0;
box-shadow: none;
}
Expand All @@ -468,6 +467,7 @@ $button-shadow-secondary-active: 0 0 0 3px transparentize($theme-light-bg-hover,
right: 0;
top: calc(2rem + 2px);
visibility: hidden;
white-space: nowrap;

&--active {
opacity: 1;
Expand All @@ -482,7 +482,6 @@ $button-shadow-secondary-active: 0 0 0 3px transparentize($theme-light-bg-hover,
cursor: pointer;
font-size: .875rem;
font-weight: normal;
max-width: 10rem;
padding: .75rem;

&:hover {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
&__header {
display: flex;
justify-content: space-between;
padding-bottom: 1rem;
}

&__action-list {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Component, Input, OnDestroy, OnInit } from '@angular/core';
import { Component, Input, OnDestroy, OnInit, ViewChild } from '@angular/core';
import { AbstractControl, FormArray, FormBuilder, FormGroup } from '@angular/forms';
import { Subject } from 'rxjs';
import { takeUntil } from 'rxjs/operators';
Expand All @@ -20,6 +20,7 @@ export class GoFileUploadComponent extends GoFormBaseComponent implements OnInit
@Input() isLoading: boolean = false;
@Input() multiple: boolean = false;
@Input() state: 'selecting' | 'selected' = 'selecting';
@ViewChild('filePicker') filePicker: any;

ngOnInit(): void {
this.fb = new FormBuilder();
Expand Down Expand Up @@ -51,6 +52,7 @@ export class GoFileUploadComponent extends GoFormBaseComponent implements OnInit
this.filePreview.push(file.name);
});
}
this.filePicker.nativeElement.value = '';
}

removeFile(index: number): void {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
@import '../../../../styles/variables';

.go-hint {
font-size: .875rem;
font-size: .75rem;
font-style: italic;
letter-spacing: $base-letter-spacing;
line-height: 1rem;
margin: $column-gutter--quarter 0;
Expand Down Expand Up @@ -43,7 +44,8 @@

&__label {
display: block;
font-size: .75rem;
font-size: 9px;
font-style: initial;
font-weight: $weight-regular;
margin-bottom: $column-gutter--quarter;
text-transform: uppercase;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
@include z-index(modal);

align-items: center;
background: transparentize($base-dark, .1);
background: rgba($base-color, .5);
display: flex;
height: 100%;
justify-content: center;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export class GoModalComponent extends GoModalOptions implements OnInit, OnDestro
loadComponent(): void {
const componentFactory: ComponentFactory<{}> = this.componentFactoryResolver.resolveComponentFactory(this.currentComponent.component);
const viewContainerRef: ViewContainerRef = this.goModalHost.viewContainerRef;

viewContainerRef.clear();
const componentRef: ComponentRef<{}> = viewContainerRef.createComponent(componentFactory);

Object.keys(this.currentComponent.bindings).forEach((key: string) => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
.go-off-canvas-backdrop {
@include z-index(off-canvas);

background: rgba($base-dark, .5);
background: rgba($base-color, .5);
height: 100vh;
left: 0;
position: fixed;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ export class GoOffCanvasComponent extends GoOffCanvasOptions implements OnInit,
this.currentOffCanvasItem.component
);
const viewContainerRef: ViewContainerRef = this.goOffCanvasHost.viewContainerRef;
viewContainerRef.clear();
const componentRef: ComponentRef<any> = viewContainerRef.createComponent(componentFactory);

Object.keys(this.currentOffCanvasItem.bindings).forEach((key: string) => {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<div class="go-progress-bar" tabindex="-1">
<ng-container
*ngTemplateOutlet="mode === 'determinate' ? determinate : indeterminate"
>
</ng-container>
</div>

<ng-template #determinate>
<div class="go-progress-bar__determinate">
<span class="go-progress-bar__determinate__left-label">
{{ leftLabel }}</span
>
<div class="go-progress-bar__determinate--track">
<div
class="go-progress-bar__determinate--indicator"
[ngStyle]="{ width: indicatorWidth + '%' }"
></div>
</div>
<span class="go-progress-bar__determinate__right-label">{{
rightLabel
}}</span>
</div>
</ng-template>

<ng-template #indeterminate>
<div class="go-progress-bar__indeterminate">
<div class="go-progress-bar__indeterminate--track"></div>
<div
class="go-progress-bar__indeterminate--indicator go-progress-bar__indeterminate--primary-indicator"
></div>
<div
class="go-progress-bar__indeterminate--indicator go-progress-bar__indeterminate--secondary-indicator"
></div>
</div>
</ng-template>
Loading