[Feature] #918 enhancement of go-date-picker #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
We should have a test to verify that the onInputCloseCalendar() is triggered on input event emitter (input)="onInputCloseCalendar()"
sudheepdivakargithub
approved these changes
Sep 22, 2023
sudheepdivakargithub
deleted the
918-Enhance_go-date-picker_by_enabling_calendar_to_open_when_date_field_is_clicked_anywhere_within_it
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently we are opening calendar only on click of calendar icon inside the date field of go-date-picker.
Resolves Enhance_go-date-picker_by_enabling_calendar_to_open_when_date_field_is_clicked_anywhere_within_it
What is the new behavior?
New behavior - where the calendar opens upon clicking anywhere within the date field of go-date-picker, rather than being restricted to only clicking on the calendar icon. This enhancement will significantly enhance the user experience, providing a more intuitive and seamless process for selecting dates.
Does this PR introduce a breaking change?