Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recoverable Transaction History Bindings for iOS #1701

Merged

Conversation

the-real-adammork
Copy link
Contributor

@the-real-adammork the-real-adammork commented Mar 25, 2022

Soundtrack of this PR: Scruscru - Chewing Gum (feat. Sunner Soul)

Motivation

iOS Bindings for Recoverable Transaction History (v1.2.0)

In this PR

  • iOS FFI/Bindings needed for the SDK to implement Recoverable Transaction History

TODO Before Merge

samdealy and others added 30 commits February 4, 2022 10:31
…tions for each of the 3 supported MemoBuilder types
… recycling tests from other parts of the repo
…get the short_address_hash from sender_memos. Added trait implementation for CompressedRistrettoPublic
…ecrypt_memo implementation into func body, add trait implementations for u66 sized array.
Copy link
Contributor

@jcape jcape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcape
Copy link
Contributor

jcape commented Apr 4, 2022

This PR is failing to build because of out-of-date Cargo.lock files. You should run a build and check in the changed Cargo.lock versions---please don't merge until someone has reviewed the changes to Cargo.lock, though :-)

@the-real-adammork
Copy link
Contributor Author

@jcape updated with the new cargo lock and linting/formatting changes

transaction/std/Cargo.toml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants