-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump elm-review from 2.11.2 to 2.12.0 #531
Conversation
25d2d1b
to
6d3bc06
Compare
Bumps [elm-review](https://github.com/jfmengels/node-elm-review) from 2.11.2 to 2.12.0. - [Release notes](https://github.com/jfmengels/node-elm-review/releases) - [Changelog](https://github.com/jfmengels/node-elm-review/blob/main/CHANGELOG.md) - [Commits](jfmengels/node-elm-review@v2.11.2...v2.12.0) --- updated-dependencies: - dependency-name: elm-review dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
6d3bc06
to
9eecc58
Compare
npm 2.12.0 supports only 2.14+ makes much confusion 🙄 |
Visit the preview URL for this PR (updated for commit c30bfdb): https://mobu-elm--pr531-dependabot-npm-and-y-9bzia11j.web.app (expires Wed, 10 Jul 2024 19:01:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c3bd1c7e660dfd047316b813d1455fa3121557d6 |
@@ -16,7 +16,7 @@ elapsedSecondsFromDurations : List Duration -> Int | |||
elapsedSecondsFromDurations durations = | |||
(durations | |||
|> List.map toMillis | |||
|> List.foldl (+) 0 | |||
|> List.sum |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -720,7 +720,7 @@ onDrop msg = | |||
|
|||
onDragOver : msg -> Attribute msg | |||
onDragOver msg = | |||
preventDefaultOn "dragover" <| Json.Decode.map (\x -> ( x, True )) <| Json.Decode.succeed msg | |||
preventDefaultOn "dragover" <| Json.Decode.succeed ((\x -> ( x, True )) <| msg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://package.elm-lang.org/packages/elm/json/latest/Json-Decode#succeed
😮
Looks working the D&D on npm run dev
Bumps elm-review from 2.11.2 to 2.12.0.
Release notes
Sourced from elm-review's releases.
Changelog
Sourced from elm-review's changelog.
Commits
5f2fcc3
2.12.04ad8d53
Update CHANGELOG7e30a2d
Resolve/ignore ESLint/TypeScript errors9230fc7
Require jfmengels/elm-review 2.14.0 or highereb4c0e5
Force build when using LOCAL_ELM_REVIEW_SRC5ce08f9
Don't only watch on the first file requestc33a954
Clean up types5bf1a20
Fix TypeScript errorsf8d84eb
Use appropriate functions to update files in watch mode86e1605
Collect extra files as DictDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)