Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy peer dependencies #118

Closed
coolsoftwaretyler opened this issue Sep 19, 2024 · 12 comments
Closed

Remove legacy peer dependencies #118

coolsoftwaretyler opened this issue Sep 19, 2024 · 12 comments
Assignees

Comments

@coolsoftwaretyler
Copy link
Collaborator

In #116, we bumped from Node v10 to v20, but that change requires us to use --legacy-peer-deps.

We should fix our peer dependencies to work correctly without the legacy flag.

@coolsoftwaretyler coolsoftwaretyler added this to the 2024 Dev Readiness milestone Sep 19, 2024
@coolsoftwaretyler
Copy link
Collaborator Author

I had someone email me about taking this on. We made a plan. I don't know their GitHub handle so I can't assign this to them yet, but we do have a volunteer to get started here (as far as I know).

I'll keep an eye on it and remind them if there isn't progress over the weekend.

@coolsoftwaretyler
Copy link
Collaborator Author

I haven't heard from them for a while, so I followed up. If I don't hear back by tomorrow I'll just take this one myself next week.

@grvv
Copy link
Contributor

grvv commented Oct 1, 2024

@coolsoftwaretyler, Hey sorry for delaying things a bit, due to issues with my personal laptop. You can assign me the issue now 🖖

@coolsoftwaretyler
Copy link
Collaborator Author

Done! Let me know if you need anything

@coolsoftwaretyler
Copy link
Collaborator Author

Hi @grvv - any update on your end?

I am going to be on vacation next week, back on Friday/Saturday. If you haven't made progress by then, I'll reassign to myself and get things moving.

Not a problem if you've been too busy to work on it, but I don't want to put this off too long and I've got a little time next weekend to work on it myself. Lots more to be done to get things up and running.

@grvv
Copy link
Contributor

grvv commented Oct 9, 2024

Hey @coolsoftwaretyler!

I didn't realize there was a bit of urgency here; I thought I could take my time and work on it gradually. I’ve cloned the repo and started diving into the code. I have a couple of light days at work starting today, so I’ll dedicate some time to it and try to make progress before your vacation.

Thanks for the reminder! 🖖

@coolsoftwaretyler
Copy link
Collaborator Author

Thanks @grvv!

@coolsoftwaretyler
Copy link
Collaborator Author

Hi @grvv - I'm hoping to get to this sometime this week. Have you made any progress? I don't want to duplicate or supersede any work you've done.

No shame at all if you haven't gotten around to it. I just want to know so I can move forward with the work. There's plenty of stuff left to do if you want to contribute something else!

Thanks for your time so far.

@grvv
Copy link
Contributor

grvv commented Oct 14, 2024

Hey @coolsoftwaretyler,

I just added my draft PR! 🖖

Here’s what I’ve done so far: I started by installing the dependencies without using the --legacy-peer-deps flag and noticed that the Babel loader needed an update. So, I went ahead and updated the Babel loader, its presets/plugins, and migrated Webpack from v3 to v4.

Next, I’ll focus on resolving the remaining peer dependencies one at a time.

PR Link

I’ve kept it as a draft for now to hear your thoughts or suggestions. I think we both should collaborate on this. I initially thought it’d be a quick fix, but it looks like it might take a bit longer since some dependencies will need code changes (e.g., switching from "react-addons-test-utils" to react-testing-library, and possibly updating the React version itself). I’ve attached a screenshot that highlights this.

Screenshot 2024-10-15 at 1 43 20 AM

Looking forward to your feedback!

@coolsoftwaretyler
Copy link
Collaborator Author

I'll take a look!

@grvv
Copy link
Contributor

grvv commented Oct 15, 2024

@coolsoftwaretyler updated PR:

#122

@coolsoftwaretyler
Copy link
Collaborator Author

coolsoftwaretyler commented Oct 15, 2024

Excellent thank you! Done in #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants