Chore/update node v20 and get scripts working #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andykog
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
@coolsoftwaretyler nice job!
I didn't any publish scripts since I doubt I have access there
Publish scripts stopped working at some point because of some new API restrictions or because of deprecation of the Travis version they relied on, anyway it's not trivial to make them working again. Also I don't think Chrome Web Store has functionality of adding contributors for extensions, so I suggest to just ping me whenever you want to publish
|
Sweet. I'll merge this and probably open a follow up to remove those scripts for clarity. Thank you! |
coolsoftwaretyler
deleted the
chore/update-node-v20-and-get-scripts-working
branch
This was referenced Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things to get the repo a little more up to date:
20.17.0in both.nvmrcand.tool-versions(I use asdf so I added that for me at least haha)--legacy-peer-depsflag to a bunch of the installation scripts for backwards compatibility with the node upgrade. Eventually we should upgrade the dependencies so we won't need this, but this works for now.--openssl-legacy-provideragainst electron. Again, I think we'll want to actually fix this, probably by upgrading to Webpack 5 and using their actual configuration that works with new open ssl versions. Again, this works for now.chromedriver, so the oldgetServerAddrwas no longer relevant, and in fact was sending ECONNREFUSED errors because it was trying to connect to ports that are longer valid.To test out these changes, pull the branch, then run
npm run bootstrapto get all the dependencies up to date.After that, run through every script in
package.json. They all seem to be working now. I didn't any publish scripts since I doubt I have access there. @andykog let me know if there are any remaining issues on those scripts.