-
-
Notifications
You must be signed in to change notification settings - Fork 90
[WIP] Try update to React 16.8 #57
Conversation
Ok, so fixing the tests was fairly easy after all. The Wondering if there is actually some hooks variant of Now we basically need to wait for react-testing-library to merge use of |
I've also upgraded other dev dependencies so we are coming to 1.0.0 with a clean slate. Should really setup some dependencies auto update app - recommendations? Jest will stay at 23 for now because |
|
Btw, do the error console logs actually mean we should be using act on unit tests or are the react-testing-library guys going to fix that somehow? |
Nevermind, just saw the comment about react-testing-library |
@xaviergonz That's what I am trying to figure in here: testing-library/react-testing-library#281
I mean something automatic. I do recall some Greenkeeper tool from the past, but not sure if there is something better. |
Alright, tests are finally fixed to the top notch again. And React 16.8.1 got released meanwhile so it's there also :) |
Take a look at https://renovatebot.com/ - it's free for Open Source Projects :) Also: Thanks for being so quick about fixing this! ❤️ |
So 16.8 is officially out with hooks. I tried updating it and a bunch of tests got broken. I will look into it later or feel free to help with that.
Once it's fixed, I want to release this as 1.0.0. There won't be probably any API change for now anyway.
Fixes #58