Will IObservableValue.observe_ and IComputedValue.observe_ be removed from exported type definitions? #3606
-
|
The observe and intercept methods are no longer exposed on arrays, maps, and boxes (as per 6.0.0 breaking changes) but they are still present on Are these methods deprecated and scheduled for removal from the exported type definitions of a later MobX release? For context, I ask because the event handler type discriminators in these types prevent us from assigning an |
Beta Was this translation helpful? Give feedback.
Replies: 1 comment 1 reply
-
|
At first glance that seems to be an oversight indeed and I think they can be safely removed. Feel free to submit a PR. If that causes compile errors that is probably because of internal usage, and we could solve that by a separate interface and upcast. |
Beta Was this translation helpful? Give feedback.
-
|
PR submitted #3608 |
Beta Was this translation helpful? Give feedback.
At first glance that seems to be an oversight indeed and I think they can be safely removed. Feel free to submit a PR. If that causes compile errors that is probably because of internal usage, and we could solve that by a separate interface and upcast.