-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peer dependency issue for [email protected] #3828
Comments
Same here, would love to get a solution to this... |
I think this was a documentation error. Mobx-react v6 won't support React v17. You should use mobx-react v7, or React v16. I opened a PR to fix the doc. |
From #3832 it superficially seems mobx-react 6 does work correctly with React 17, just the peerDependencies is outdated (e.g. that version is older than React 17 itself). That could be changed by updating the package.json, but since we in principle don't release patches on 3 major version behind packages, I recommend to instead upgrade mobx-react to a newer version. |
Closing as documentation has been updated per #3832. Thanks for the investigation @robhybrid! |
Intended outcome:
npm install
successfully with no peer dependency issues when on React16.8.0
or higher, as stated in docs:Actual outcome:
Getting error message:
How to reproduce the issue:
Try installing
mobx-react
withReact
version17.0.1
.For some reason I am unable to reproduce this issue in Sandbox / Expo but I am able to on this repo which was created with
npx [email protected] init
and adding[email protected]
and[email protected]
.Versions
Listed in package.json of test repo.
The text was updated successfully, but these errors were encountered: