-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ESM output to .mjs #1131
Conversation
@rossipedia could you review this one? |
@geelen there's another minor change you'll need to make: I'm not 100% on the ramifications of this change at the moment, either. While ideally moving to |
I personally dislike |
Thanks & merged. Will be part of next release. Probably blowing up in somebodies face like any module / bundling related change ever did in the past 😢 |
Can somebody confirm this will work on React Native as expected as well? |
React native does not support Rolled back this PR and created a fresh follow up issue: #1172 |
Also, since I posted this PR, Node has gotten experimental support for modules which... I don't think should change things but who knows!
That's my experience too. Good luck! |
I've just been playing around with the @std/esm loader, which makes reference to the fact that Node's ES6 module support is going to be tied to the file extension
*.mjs
. I admit I don't know much context around this issue but I saw this and thought it might make sense to follow the new convention.