State version cleanup #3764
Merged
State version cleanup #3764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rops not propagationg, fixes #3728
|
urugator
reviewed
Oct 1, 2023
| // BC: we will use local state version if global isn't available. | ||
| // It should behave as previous implementation - tearing is still present, | ||
| // stateVersion that 'ticks' for every time the reaction fires | ||
| // tearing is still present, |
There was a problem hiding this comment.
Is it? I think you can remove these...
urugator
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #3763, cleanup global stateVersion. Kept initObservable as is, as it handles several flags around warnings etc better.