buildinfo: add build attributes and frontend #2476

crazy-max · 2021-11-22T08:26:25Z

follow-up #2311

store additional build dependencies such as frontend and attrs.

# buildkit
$ docker buildx build --push --platform linux/amd64,linux/arm64 \
  --build-arg "BUILDKIT_CONTEXT_KEEP_GIT_DIR=1" \
  --tag "crazymax/buildkit:buildattrs" \
  https://github.com/crazy-max/buildkit.git#buildinfo-attrs

# frontend
$ docker buildx build --push --platform linux/amd64,linux/arm64 \
  --build-arg "CHANNEL=mainline" \
  --build-arg "BUILDKIT_CONTEXT_KEEP_GIT_DIR=1" \
  --tag "crazymax/dockerfile:buildattrs" \
  --file "./frontend/dockerfile/cmd/dockerfile-frontend/Dockerfile" \
  https://github.com/crazy-max/buildkit.git#buildinfo-attrs

# buildx to inline build attrs (opt-in atm)
$ docker buildx bake https://github.com/crazy-max/buildx.git#inline-buildattrs binaries
$ cp ./bin/buildx ~/.docker/cli-plugins/docker-buildx

Pre-built frontend # syntax=crazymax/dockerfile:buildattrs and BuildKit image crazymax/buildkit:buildattrs can be used to test this feature:

$ docker buildx create --name buildattrs --driver-opt image=crazymax/buildkit:buildattrs --use

# buildattrs enabled
$ docker buildx build --metadata-file metadata.json \
  --load --tag buildattrs:latest \
  --build-arg BUILDKIT_INLINE_BUILDINFO_ATTRS=1 \
  https://github.com/crazy-max/buildkit-buildsources-test.git#master

$ cat metadata.json | jq -r '."containerimage.buildinfo"' | base64 --decode | jq
{
  "frontend": "dockerfile.v0",
  "attrs": {
    "cmdline": "crazymax/dockerfile:buildattrs",
    "context": "https://github.com/crazy-max/buildkit-buildsources-test.git#master",
    "filename": "Dockerfile",
    "source": "crazymax/dockerfile:buildattrs"
  },
  "sources": [
    {
      "type": "docker-image",
      "ref": "docker.io/docker/buildx-bin:0.6.1@sha256:a652ced4a4141977c7daaed0a074dcd9844a78d7d2615465b12f433ae6dd29f0",
      "pin": "sha256:a652ced4a4141977c7daaed0a074dcd9844a78d7d2615465b12f433ae6dd29f0"
    },
    {
      "type": "docker-image",
      "ref": "docker.io/library/alpine:3.13",
      "pin": "sha256:026f721af4cf2843e07bba648e158fb35ecc876d822130633cc49f707f0fc88c"
    },
    {
      "type": "docker-image",
      "ref": "docker.io/moby/buildkit:v0.9.0",
      "pin": "sha256:8dc668e7f66db1c044aadbed306020743516a94848793e0f81f94a087ee78cab"
    },
    {
      "type": "docker-image",
      "ref": "docker.io/tonistiigi/xx@sha256:21a61be4744f6531cb5f33b0e6f40ede41fa3a1b8c82d5946178f80cc84bfc04",
      "pin": "sha256:21a61be4744f6531cb5f33b0e6f40ede41fa3a1b8c82d5946178f80cc84bfc04"
    },
    {
      "type": "git",
      "ref": "https://github.com/crazy-max/buildkit-buildsources-test.git#master",
      "pin": "43a8bf9c351abf64b0865a6a0548a1de1ded40a8"
    },
    {
      "type": "http",
      "ref": "https://raw.githubusercontent.com/moby/moby/master/README.md",
      "pin": "sha256:419455202b0ef97e480d7f8199b26a721a417818bc0e2d106975f74323f25e6c"
    }
  ]
}

$ docker image save buildattrs:latest | tar -ax --exclude 'manifest.json' --wildcards '*.json' -O | jq -r '."moby.buildkit.buildinfo.v1"' | base64 --decode | jq
{
  "frontend": "dockerfile.v0",
  "attrs": {
    "cmdline": "crazymax/dockerfile:buildattrs",
    "context": "https://github.com/crazy-max/buildkit-buildsources-test.git#master",
    "filename": "Dockerfile",
    "source": "crazymax/dockerfile:buildattrs"
  },
  "sources": [
    {
      "type": "docker-image",
      "ref": "docker.io/docker/buildx-bin:0.6.1@sha256:a652ced4a4141977c7daaed0a074dcd9844a78d7d2615465b12f433ae6dd29f0",
      "pin": "sha256:a652ced4a4141977c7daaed0a074dcd9844a78d7d2615465b12f433ae6dd29f0"
    },
    {
      "type": "docker-image",
      "ref": "docker.io/library/alpine:3.13",
      "pin": "sha256:026f721af4cf2843e07bba648e158fb35ecc876d822130633cc49f707f0fc88c"
    },
    {
      "type": "docker-image",
      "ref": "docker.io/moby/buildkit:v0.9.0",
      "pin": "sha256:8dc668e7f66db1c044aadbed306020743516a94848793e0f81f94a087ee78cab"
    },
    {
      "type": "docker-image",
      "ref": "docker.io/tonistiigi/xx@sha256:21a61be4744f6531cb5f33b0e6f40ede41fa3a1b8c82d5946178f80cc84bfc04",
      "pin": "sha256:21a61be4744f6531cb5f33b0e6f40ede41fa3a1b8c82d5946178f80cc84bfc04"
    },
    {
      "type": "git",
      "ref": "https://github.com/crazy-max/buildkit-buildsources-test.git#master",
      "pin": "43a8bf9c351abf64b0865a6a0548a1de1ded40a8"
    },
    {
      "type": "http",
      "ref": "https://raw.githubusercontent.com/moby/moby/master/README.md",
      "pin": "sha256:419455202b0ef97e480d7f8199b26a721a417818bc0e2d106975f74323f25e6c"
    }
  ]
}

# buildattrs disabled (default)
$ docker buildx build --metadata-file metadata.json \
  --load --tag buildattrs:latest \
  https://github.com/crazy-max/buildkit-buildsources-test.git#master

$ cat metadata.json | jq -r '."containerimage.buildinfo"' | base64 --decode | jq
{
  "frontend": "dockerfile.v0",
  "attrs": {
    "cmdline": "crazymax/dockerfile:buildattrs",
    "context": "https://github.com/crazy-max/buildkit-buildsources-test.git#master",
    "filename": "Dockerfile",
    "source": "crazymax/dockerfile:buildattrs"
  },
  "sources": [
    {
      "type": "docker-image",
      "ref": "docker.io/docker/buildx-bin:0.6.1@sha256:a652ced4a4141977c7daaed0a074dcd9844a78d7d2615465b12f433ae6dd29f0",
      "pin": "sha256:a652ced4a4141977c7daaed0a074dcd9844a78d7d2615465b12f433ae6dd29f0"
    },
    {
      "type": "docker-image",
      "ref": "docker.io/library/alpine:3.13",
      "pin": "sha256:026f721af4cf2843e07bba648e158fb35ecc876d822130633cc49f707f0fc88c"
    },
    {
      "type": "docker-image",
      "ref": "docker.io/moby/buildkit:v0.9.0",
      "pin": "sha256:8dc668e7f66db1c044aadbed306020743516a94848793e0f81f94a087ee78cab"
    },
    {
      "type": "docker-image",
      "ref": "docker.io/tonistiigi/xx@sha256:21a61be4744f6531cb5f33b0e6f40ede41fa3a1b8c82d5946178f80cc84bfc04",
      "pin": "sha256:21a61be4744f6531cb5f33b0e6f40ede41fa3a1b8c82d5946178f80cc84bfc04"
    },
    {
      "type": "git",
      "ref": "https://github.com/crazy-max/buildkit-buildsources-test.git#master",
      "pin": "43a8bf9c351abf64b0865a6a0548a1de1ded40a8"
    },
    {
      "type": "http",
      "ref": "https://raw.githubusercontent.com/moby/moby/master/README.md",
      "pin": "sha256:419455202b0ef97e480d7f8199b26a721a417818bc0e2d106975f74323f25e6c"
    }
  ]
}

$ docker image save buildattrs:latest | tar -ax --exclude 'manifest.json' --wildcards '*.json' -O | jq -r '."moby.buildkit.buildinfo.v1"' | base64 --decode | jq
{
  "frontend": "dockerfile.v0",
  "sources": [
    {
      "type": "docker-image",
      "ref": "docker.io/docker/buildx-bin:0.6.1@sha256:a652ced4a4141977c7daaed0a074dcd9844a78d7d2615465b12f433ae6dd29f0",
      "pin": "sha256:a652ced4a4141977c7daaed0a074dcd9844a78d7d2615465b12f433ae6dd29f0"
    },
    {
      "type": "docker-image",
      "ref": "docker.io/library/alpine:3.13",
      "pin": "sha256:026f721af4cf2843e07bba648e158fb35ecc876d822130633cc49f707f0fc88c"
    },
    {
      "type": "docker-image",
      "ref": "docker.io/moby/buildkit:v0.9.0",
      "pin": "sha256:8dc668e7f66db1c044aadbed306020743516a94848793e0f81f94a087ee78cab"
    },
    {
      "type": "docker-image",
      "ref": "docker.io/tonistiigi/xx@sha256:21a61be4744f6531cb5f33b0e6f40ede41fa3a1b8c82d5946178f80cc84bfc04",
      "pin": "sha256:21a61be4744f6531cb5f33b0e6f40ede41fa3a1b8c82d5946178f80cc84bfc04"
    },
    {
      "type": "git",
      "ref": "https://github.com/crazy-max/buildkit-buildsources-test.git#master",
      "pin": "43a8bf9c351abf64b0865a6a0548a1de1ded40a8"
    },
    {
      "type": "http",
      "ref": "https://raw.githubusercontent.com/moby/moby/master/README.md",
      "pin": "sha256:419455202b0ef97e480d7f8199b26a721a417818bc0e2d106975f74323f25e6c"
    }
  ]
}

tonistiigi

I think we should pick all build-args + known opts like context, filename etc only. If variable changes build result then it should be picked.

Need to think about what to do with frontend inputs. We should at least mark somehow that they were used. DefinitionOp should carry the buildinfo of the inputs so it could be added to the main one.

We also discussed that a client should be able to send its own data for this. Eg. bake to send its args/target. This can be follow-up as well.

crazy-max · 2021-12-21T01:38:56Z

@tonistiigi I wonder where we should add the opt-in. New image output key? (e.g., buildinfo-attrs=false) or a frontend opt (e.g., buildinfo-attrs + build-arg:BUILDKIT_KEEP_BUILDINFO_ATTRS)? The later sound better.

tonistiigi · 2022-01-04T21:18:43Z

I think opt-in should be just for the image inline. So as we currently have BUILDKIT_INLINE_CACHE we can have BUILDKIT_INLINE_BUILDINFO_ATTRS. We can also do the exporter attribute for the image exporter.

tonistiigi

I'm not sure about the special InlineBuildInfoAttrs handling. It looks out of place compared to the other exporter attrs.

I think we should just use the regular exporter attr for image exporter like we do today for the image exporter. Just the regular map like for other options.

The frontend(dockerfile) shouldn't check if attr exporting is enabled or not, just like for buildinfo. It just always sets it and if there is no opt-in then the image exporter just clears the whole attr section.

So the base opt-in will be with output option. For the build-arg opt-in we can make it in buildx like for the inline cache https://github.com/docker/buildx/blob/4c938c77bab00dbe983597b7d29f2e2eb19e8000/build/build.go#L358 .

Not for this PR but looking at the current buildinfo exporter attr buildinfo=[all,imageconfig,metadata,none], I'm not sure what the point of the buildinfo=metadata was for there. Doesn't it make more sense to have it as bool and metadata is just always enabled. What does image exporter have to do with exporting metadata.json at all? I assume that other than inlining in config this all still works when I'm not exporting an image. In that case we would have 2 exporter attr buildinfo, buildinfo-attrs . Currently by default buildinfo would default to true and buildinfo-attrs to false. We could even add build-arg config for both of them.

crazy-max · 2022-01-08T01:30:32Z

I'm not sure about the special InlineBuildInfoAttrs handling. It looks out of place compared to the other exporter attrs.

I think we should just use the regular exporter attr for image exporter like we do today for the image exporter. Just the regular map like for other options.

The frontend(dockerfile) shouldn't check if attr exporting is enabled or not, just like for buildinfo. It just always sets it and if there is no opt-in then the image exporter just clears the whole attr section.

So the base opt-in will be with output option. For the build-arg opt-in we can make it in buildx like for the inline cache https://github.com/docker/buildx/blob/4c938c77bab00dbe983597b7d29f2e2eb19e8000/build/build.go#L358 .

Yes, it looks better that way, thanks for pointing that out.

Not for this PR but looking at the current buildinfo exporter attr buildinfo=[all,imageconfig,metadata,none], I'm not sure what the point of the buildinfo=metadata was for there. Doesn't it make more sense to have it as bool and metadata is just always enabled. What does image exporter have to do with exporting metadata.json at all?

Yes, initially the idea was to be able to choose the export mode. I agree a bool is enough to enable/disable inline buildinfo in image config. Will work on that in a follow-up.

I assume that other than inlining in config this all still works when I'm not exporting an image.

That's the tricky part. The metadata response is always null if no exporter is specified. We need at least one of them (oci, local, image, tar) otherwise the solver is never called iiuc.

In that case we would have 2 exporter attr buildinfo, buildinfo-attrs . Currently by default buildinfo would default to true and buildinfo-attrs to false. We could even add build-arg config for both of them.

SGTM

tonistiigi · 2022-01-08T02:00:26Z

The metadata response is always null if no exporter is specified. We need at least one of them (oci, local, image, tar) otherwise the solver is never called iiuc.

I think we should try to fix this. I don't know exactly what the issue is in here, maybe we need like a exporter post-step. I can see it being useful without exporting an image as well. But let's address this part in a follow-up PR.

tonistiigi · 2022-01-11T05:16:35Z

docs/build-repro.md

+  "attrs": {
+    "build-arg:foo": "bar",
+    "cmdline": "crazymax/dockerfile:master",
+    "context": "https://github.com/crazy-max/buildkit-buildsources-test.git#master",


something to think about: would be good if we could capture if build used a local context or no context. That is important info for replay.

If a local context is being used then context field is not set:

"attrs": { "cmdline": "crazymax/dockerfile:buildattrs", "filename": "Dockerfile", "source": "crazymax/dockerfile:buildattrs" }

Do you think it's worth adding something like "context": "local"?

If a local context is being used then context field is not set:

Yes but it might also be that there is no local context at all. Where you just build from Dockerfile with no COPY commands from context. On replay, we should be able to give an error when the local source is not passed by the user and required for replay, but not when it is not required at all.

docs/build-repro.md

util/buildinfo/buildinfo.go

solver/llbsolver/solver.go

tonistiigi · 2022-01-11T05:33:38Z

util/buildinfo/buildinfo.go

 	}
 	return bi, nil
 }
+
+var knownAttrs = []string{


Is this list Dockerfile specific or generic enough to be in here?

Yes this is Dockerfile specific atm:

buildkit/frontend/dockerfile/builder/build.go

Lines 44 to 61 in ffe2301

keyTarget = "target"

keyFilename = "filename"

keyCacheFrom = "cache-from" // for registry only. deprecated in favor of keyCacheImports

keyCacheImports = "cache-imports" // JSON representation of []CacheOptionsEntry

keyCgroupParent = "cgroup-parent"

keyContextSubDir = "contextsubdir"

keyForceNetwork = "force-network-mode"

keyGlobalAddHosts = "add-hosts"

keyHostname = "hostname"

keyImageResolveMode = "image-resolve-mode"

keyMultiPlatform = "multi-platform"

keyNameContext = "contextkey"

keyNameDockerfile = "dockerfilekey"

keyNoCache = "no-cache"

keyOverrideCopyImage = "override-copy-image" // remove after CopyOp implemented

keyShmSize = "shm-size"

keyTargetPlatform = "platform"

keyUlimit = "ulimit"

util/buildinfo/buildinfo.go

tonistiigi

Could we have some integration tests for this. Something that tests the opt-in, default behavior, inlining. If we add the case where frontend can also provide state via Metadata then that case as well (with a client.Build you can return the result metadata, look a build-context tests for example).

frontend/result.go

solver/llbsolver/bridge.go

tonistiigi · 2022-02-11T19:02:20Z

util/buildinfo/buildinfo.go

+}
+
+// ReduceMap joins map string (union)
+func ReduceMap(m1, m2 map[string]string) map[string]string {


if m1 is map[string]*string then we can remove the key if it is nil.

util/buildinfo/buildinfo.go

solver/llbsolver/bridge.go

Signed-off-by: CrazyMax <[email protected]>

util/buildinfo/buildinfo.go

Signed-off-by: CrazyMax <[email protected]>

tonistiigi reviewed Nov 22, 2021

View reviewed changes

crazy-max force-pushed the buildinfo-attrs branch from 8117e19 to da5482f Compare November 24, 2021 07:21

crazy-max force-pushed the buildinfo-attrs branch from da5482f to e08215d Compare December 6, 2021 11:10

crazy-max force-pushed the buildinfo-attrs branch from e08215d to 311992f Compare December 15, 2021 15:04

crazy-max force-pushed the buildinfo-attrs branch from 311992f to 3e718e7 Compare January 7, 2022 15:54

crazy-max marked this pull request as ready for review January 7, 2022 18:27

crazy-max requested a review from tonistiigi January 7, 2022 18:27

crazy-max force-pushed the buildinfo-attrs branch from 9ac574e to 1b1e589 Compare January 7, 2022 20:39

tonistiigi reviewed Jan 8, 2022

View reviewed changes

crazy-max force-pushed the buildinfo-attrs branch from 1b1e589 to 839cc67 Compare January 8, 2022 15:44

crazy-max mentioned this pull request Jan 8, 2022

build: inline buildinfo attrs docker/buildx#908

Merged

crazy-max requested a review from tonistiigi January 8, 2022 15:56

crazy-max marked this pull request as draft January 8, 2022 16:44

crazy-max marked this pull request as ready for review January 8, 2022 16:53

tonistiigi reviewed Jan 11, 2022

View reviewed changes

crazy-max force-pushed the buildinfo-attrs branch 4 times, most recently from c190de4 to 4d0a96c Compare January 11, 2022 11:04

crazy-max marked this pull request as draft January 12, 2022 06:22

tonistiigi added this to the v0.10.0 milestone Jan 18, 2022

crazy-max force-pushed the buildinfo-attrs branch from 4b5bd4f to 94e9bbd Compare January 27, 2022 12:59

crazy-max force-pushed the buildinfo-attrs branch from 6b4d2bc to 0a33a83 Compare February 3, 2022 23:28

crazy-max marked this pull request as ready for review February 3, 2022 23:44

tonistiigi reviewed Feb 4, 2022

View reviewed changes

frontend/result.go Outdated Show resolved Hide resolved

crazy-max force-pushed the buildinfo-attrs branch from 0a33a83 to 6c3abec Compare February 4, 2022 11:48

tonistiigi reviewed Feb 11, 2022

View reviewed changes

solver/llbsolver/bridge.go Outdated Show resolved Hide resolved

tonistiigi reviewed Feb 11, 2022

View reviewed changes

util/buildinfo/buildinfo.go Outdated Show resolved Hide resolved

crazy-max force-pushed the buildinfo-attrs branch from 22de8fd to 70703d4 Compare February 11, 2022 21:19

crazy-max requested a review from tonistiigi February 11, 2022 21:26

tonistiigi reviewed Feb 11, 2022

View reviewed changes

solver/llbsolver/bridge.go Show resolved Hide resolved

crazy-max force-pushed the buildinfo-attrs branch from 70703d4 to 246bd15 Compare February 12, 2022 01:38

crazy-max requested a review from tonistiigi February 12, 2022 09:42

crazy-max force-pushed the buildinfo-attrs branch from 246bd15 to 409c28c Compare February 14, 2022 08:50

crazy-max added 9 commits February 14, 2022 21:55

buildinfo: refactor

b4e37a8

Signed-off-by: CrazyMax <[email protected]>

buildinfo: add build attributes and frontend

c29411b

Signed-off-by: CrazyMax <[email protected]>

buildinfo: opt-in inline build attributes

83a483a

Signed-off-by: CrazyMax <[email protected]>

buildinfo: filter out control args

7d0f8e4

Signed-off-by: CrazyMax <[email protected]>

buildinfo: set frontend attrs to bridge result

b2e5d19

Signed-off-by: CrazyMax <[email protected]>

buildinfo: client tests

b352c9d

Signed-off-by: CrazyMax <[email protected]>

buildinfo: dockerfile tests

ed62fae

Signed-off-by: CrazyMax <[email protected]>

buildinfo: use metadata to set frontend build sources

cdaafb9

Signed-off-by: CrazyMax <[email protected]>

docs: update metadata output example with buildinfo

b42e547

Signed-off-by: CrazyMax <[email protected]>

crazy-max force-pushed the buildinfo-attrs branch from ac1f35b to e6efbe0 Compare February 14, 2022 20:55

tonistiigi reviewed Feb 14, 2022

View reviewed changes

util/buildinfo/buildinfo.go Outdated Show resolved Hide resolved

crazy-max force-pushed the buildinfo-attrs branch 2 times, most recently from 0440083 to 6089f8a Compare February 14, 2022 21:19

tonistiigi approved these changes Feb 14, 2022

View reviewed changes

buildinfo: check nil attrs

9cd97fb

Signed-off-by: CrazyMax <[email protected]>

crazy-max force-pushed the buildinfo-attrs branch from 6089f8a to 9cd97fb Compare February 14, 2022 21:55

crazy-max requested a review from tonistiigi February 14, 2022 22:08

tonistiigi merged commit 0fab75a into moby:master Feb 14, 2022

crazy-max deleted the buildinfo-attrs branch February 14, 2022 22:30

This was referenced Feb 16, 2022

buildinfo: export metadata without exporter #2645

Merged

buildinfo: named input contexts support #2654

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

buildinfo: add build attributes and frontend #2476

buildinfo: add build attributes and frontend #2476

crazy-max commented Nov 22, 2021 •

edited

Loading

tonistiigi left a comment

crazy-max commented Dec 21, 2021

tonistiigi commented Jan 4, 2022

tonistiigi left a comment

crazy-max commented Jan 8, 2022 •

edited

Loading

tonistiigi commented Jan 8, 2022

tonistiigi Jan 11, 2022

crazy-max Jan 11, 2022

tonistiigi Jan 12, 2022

tonistiigi Jan 11, 2022

crazy-max Jan 11, 2022

tonistiigi left a comment

tonistiigi Feb 11, 2022

	keyTarget = "target"
	keyFilename = "filename"
	keyCacheFrom = "cache-from" // for registry only. deprecated in favor of keyCacheImports
	keyCacheImports = "cache-imports" // JSON representation of []CacheOptionsEntry
	keyCgroupParent = "cgroup-parent"
	keyContextSubDir = "contextsubdir"
	keyForceNetwork = "force-network-mode"
	keyGlobalAddHosts = "add-hosts"
	keyHostname = "hostname"
	keyImageResolveMode = "image-resolve-mode"
	keyMultiPlatform = "multi-platform"
	keyNameContext = "contextkey"
	keyNameDockerfile = "dockerfilekey"
	keyNoCache = "no-cache"
	keyOverrideCopyImage = "override-copy-image" // remove after CopyOp implemented
	keyShmSize = "shm-size"
	keyTargetPlatform = "platform"
	keyUlimit = "ulimit"

buildinfo: add build attributes and frontend #2476

buildinfo: add build attributes and frontend #2476

Conversation

crazy-max commented Nov 22, 2021 • edited Loading

tonistiigi left a comment

Choose a reason for hiding this comment

crazy-max commented Dec 21, 2021

tonistiigi commented Jan 4, 2022

tonistiigi left a comment

Choose a reason for hiding this comment

crazy-max commented Jan 8, 2022 • edited Loading

tonistiigi commented Jan 8, 2022

tonistiigi Jan 11, 2022

Choose a reason for hiding this comment

crazy-max Jan 11, 2022

Choose a reason for hiding this comment

tonistiigi Jan 12, 2022

Choose a reason for hiding this comment

tonistiigi Jan 11, 2022

Choose a reason for hiding this comment

crazy-max Jan 11, 2022

Choose a reason for hiding this comment

tonistiigi left a comment

Choose a reason for hiding this comment

tonistiigi Feb 11, 2022

Choose a reason for hiding this comment

crazy-max commented Nov 22, 2021 •

edited

Loading

crazy-max commented Jan 8, 2022 •

edited

Loading