filesync: escape special query characters #4009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that files with '%' and '+' can still be properly copied. To prevent regressions, this also adds in a couple of example test cases. Signed-off-by: Justin Chadwell <[email protected]>
crazy-max
approved these changes
Jul 11, 2023
tonistiigi
reviewed
Jul 12, 2023
|
Without this patch though, we break a new daemon with a new client when the path contains |
|
LGTM |
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
filesync-ascii-special-chars
branch
from
cc1dcb2
to
48b6240
Compare
tonistiigi
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Fixes #3946 (comment)
This ensures that files with '%' and '+' can still be properly copied.
To prevent regressions, this also adds in a couple of example test cases.