Fix missing chown/chmod when using parents flag with ADD/COPY command

[nobiit]

When using the parents flag, it will add CopyInfo to the end of opts

buildkit/frontend/dockerfile/dockerfile2llb/convert.go

Lines 1232 to 1238 in ef61ad1

	if cfg.parents {
	path := strings.TrimPrefix(src, "/")
	opts = append(opts, &llb.CopyInfo{
	IncludePatterns: []string{path},
	})
	src = "/"
	}

And since it's the last, it will replace any opts in front. So the chmod/chown flags in front will be disabled (like they don't exist).

buildkit/client/llb/fileop.go

Lines 481 to 483 in ef61ad1

	func (mi *CopyInfo) SetCopyOption(mi2 *CopyInfo) {
	*mi2 = *mi
	}

We should take it forward. Like this

buildkit/frontend/dockerfile/dockerfile2llb/convert.go

Lines 1206 to 1209 in ef61ad1

	opts := append([]llb.CopyOption{&llb.CopyInfo{
	Mode: mode,
	CreateDestPath: true,
	}}, copyOpt...)

[jedevc]

Not quite sure how the change in this PR is supposed to resolve the issue?

---

The right way to resolve this is to create the CopyInfo struct before checking cfg.parents, and then set IncludePatterns based on that.

We can then add the CopyInfo struct to the opts list - you're right, the last one will take precedence, so we should take care to only add it once.

[nobiit]

Thanks for @jedevc suggestion, I have rewritten the code the way you suggested. I think it will be clearer and easier to read

[jedevc]

Thanks @nobiit! 🎉 🎉 (welcome to buildkit btw!)