docs: update environment replacement #5144
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mitsuru Kariya <[email protected]>
dvdksn
reviewed
Sep 12, 2024
| @@ -309,10 +309,10 @@ PS E:\myproject> | |||
|
|
|||
| ## Environment replacement | |||
There was a problem hiding this comment.
I like the update, but it made me realize that we should rephrase this section a little bit more. "Environment variables" specifically means variables set in the system. Build arguments are never set on the system-level, they're interpreted when we're building.
I think s/environment variables/variables/g (within this section) would be an appropriate change to make. (And ## Variable replacement, or maybe ## Variable substitution for the section title.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Environment replacement section in the Dockerfile reference.