[test] update to runc v1.2.0-rc.2 #5157
Draft
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
commented
Jul 16, 2024
Dockerfile
Outdated
| @@ -66,7 +66,7 @@ RUN set -e; xx-apk add musl-dev gcc libseccomp-dev libseccomp-static; \ | |||
| RUN --mount=from=runc-src,src=/usr/src/runc,target=. \ | |||
| --mount=target=/root/.cache,type=cache <<EOT | |||
| set -ex | |||
| CGO_ENABLED=1 xx-go build -mod=vendor -ldflags '-extldflags -static' -tags 'apparmor seccomp netgo cgo static_build osusergo' -o /usr/bin/runc ./ | |||
| CGO_ENABLED=1 xx-go build -mod=vendor -ldflags '-extldflags -static' -tags 'apparmor seccomp netgo cgo static_build osusergo runc_nodmz' -o /usr/bin/runc ./ | |||
There was a problem hiding this comment.
@kolyshkin iiuc building runc-dmz separately and running the go generate before building runc itself is now the recommended way of building runc? When building without runc_nodmz tag with regular go build the runc binary seems to work fine as well, but I guess it is slower? Is the runc-dmz binary itself always throwaway? Is there a recommended way to check that runc was built with optimal dmz?
Signed-off-by: Tonis Tiigi <[email protected]>
tonistiigi
force-pushed
the
runc-v1.2.0-rc.2
branch
from
7f38245
to
e0a1b32
Compare
tonistiigi
commented
Jul 16, 2024
| --mount=target=/root/.cache,type=cache <<EOT | ||
| set -ex | ||
| if [ -f libcontainer/dmz/_dmz.c ]; then | ||
| case "$(xx-info arch)" in | ||
| amd64|arm64|s390x|riscv64|386 ) |
There was a problem hiding this comment.
That's not quite the same list as https://github.com/opencontainers/runc/blob/v1.2.0-rc.2/libcontainer/dmz/Makefile#L8 but arm & ppc64le give errors to me. Not sure if Alpine, clang or I'm passing some wrong flags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.