Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add OCI image annotations to Dockerfile frontend images #5197

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

candrews
Copy link
Contributor

@candrews
Copy link
Contributor Author

@crazy-max how's this PR look?

@candrews
Copy link
Contributor Author

candrews commented Aug 5, 2024

@crazy-max friendly bump

@crazy-max crazy-max added this to the v0.16.0 milestone Aug 6, 2024
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes so we can verify this on PR like the BuildKit image

candrews and others added 2 commits August 7, 2024 11:53
Co-authored-by: CrazyMax <[email protected]>
Signed-off-by: Craig Andrews <[email protected]>
Co-authored-by: CrazyMax <[email protected]>
Signed-off-by: Craig Andrews <[email protected]>
@github-actions github-actions bot added the area/hack building buildkit itself label Aug 7, 2024
@candrews
Copy link
Contributor Author

candrews commented Aug 7, 2024

Some changes so we can verify this on PR like the BuildKit image

Thank you, those changes look good to me and have been applied.

@candrews candrews requested a review from crazy-max August 7, 2024 15:54
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@crazy-max crazy-max merged commit 83ec902 into moby:master Aug 8, 2024
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add OCI image annotations to docker hub published moby/buildkit images
2 participants