Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: frontend/dockerfile: update integration tests for windows/wcow (part 2) #5200

Merged
merged 1 commit into from
Sep 23, 2024
Merged

tests: frontend/dockerfile: update integration tests for windows/wcow (part 2) #5200

merged 1 commit into from
Sep 23, 2024

Conversation

billywr
Copy link

@billywr billywr commented Jul 30, 2024 •
edited
Loading

Updated tests in frontend/dockerfile/dockerfile_test.go to run on Windows.
Partially addressing #4485

  • testDockerignoreInvalid
  • testDockerignore
  • testExposeExpansion
  • testDockerfileAddArchiveWildcard
  • testDockerfileInvalidInstruction
  • testWorkdirExists
  • testOutOfOrderStage
  • testWorkdirUser
  • testEmptyWildcard
  • testLabels
  • testWildcardRenameCache
  • testReproducibleIDs
  • testPlatformArgsImplicit
  • testFrontendSubrequests
  • testFrontendEvaluate

@billywr billywr force-pushed the wcow-integration-test branch 6 times, most recently from 753c12a to 6b7aae5 Compare August 5, 2024 17:44
@billywr billywr marked this pull request as ready for review August 12, 2024 09:07
@billywr billywr changed the title Add Windows container support in integration tests tests: frontend/dockerfile: update integration tests for windows/WCOW Aug 12, 2024
profnandaa
profnandaa reviewed Aug 14, 2024
View reviewed changes
frontend/dockerfile/dockerfile_test.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile_test.go Outdated Show resolved Hide resolved
@billywr billywr force-pushed the wcow-integration-test branch 3 times, most recently from 33c594b to 1386539 Compare August 14, 2024 13:56
@billywr billywr marked this pull request as draft August 14, 2024 14:07
@billywr billywr changed the title tests: frontend/dockerfile: update integration tests for windows/WCOW tests: frontend/dockerfile: update integration tests for windows-part2 Aug 15, 2024
@billywr billywr changed the title tests: frontend/dockerfile: update integration tests for windows-part2 tests: frontend/dockerfile: update integration tests for windows/wcow(part2) Aug 15, 2024
@billywr billywr changed the title tests: frontend/dockerfile: update integration tests for windows/wcow(part2) tests: frontend/dockerfile: update integration tests for windows/wcow(part 2) Aug 15, 2024
@billywr billywr changed the title tests: frontend/dockerfile: update integration tests for windows/wcow(part 2) tests: frontend/dockerfile: update integration tests for windows/wcow (part 2) Aug 15, 2024
@billywr billywr force-pushed the wcow-integration-test branch 2 times, most recently from c485113 to 58ce875 Compare August 15, 2024 11:17
@billywr billywr force-pushed the wcow-integration-test branch 2 times, most recently from 0382e39 to 2c68d53 Compare August 19, 2024 07:48
@billywr billywr marked this pull request as ready for review August 19, 2024 08:45
profnandaa
profnandaa reviewed Aug 20, 2024
View reviewed changes
frontend/dockerfile/dockerfile_test.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile_test.go Outdated Show resolved Hide resolved
frontend/dockerfile/dockerfile_test.go Outdated Show resolved Hide resolved
util/testutil/integration/sandbox.go Outdated Show resolved Hide resolved
@billywr billywr force-pushed the wcow-integration-test branch 2 times, most recently from 188d2eb to 4ec7603 Compare August 20, 2024 09:27
profnandaa
profnandaa suggested changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@profnandaa profnandaa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the change you just pushed, so many stray files, must have been a mistake? Also you can refrain from pushing changes after PR approval or at least send a comment on what has changed and why.

profnandaa
profnandaa approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, was looking at the wrong diff. I think you rebased with master. Can still be sending a note that the push is just a rebase.

@billywr billywr force-pushed the wcow-integration-test branch 3 times, most recently from 1b4ad52 to 37d4707 Compare September 6, 2024 08:30
@billywr billywr force-pushed the wcow-integration-test branch 4 times, most recently from 6e07f28 to f79d2e8 Compare September 23, 2024 10:15
@tonistiigi tonistiigi merged commit 9837185 into moby:master Sep 23, 2024
90 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazy-max crazy-max crazy-max approved these changes

@tonistiigi tonistiigi tonistiigi approved these changes

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
area/dockerfile area/frontend area/testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@billywr @profnandaa @tonistiigi @crazy-max @thompson-shaun