executor: detect containers killed by OOMKiller #5260
Merged
+52
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If container exits with error and has invoked OOMKiller mark the origin error as ENOMEM so that it can be detected on the client side. gRPC will set ENOMEM as codes.ResouceExhausted based on moby#5182 Signed-off-by: Tonis Tiigi <[email protected]>
crazy-max
approved these changes
Aug 22, 2024
billywr
pushed a commit
to billywr/buildkit
that referenced
this pull request
Aug 23, 2024
executor: detect containers killed by OOMKiller Signed-off-by: Billy Owire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If container exits with error and has invoked OOMKiller mark the origin error as ENOMEM so that it can be detected on the client side.
gRPC will set ENOMEM as codes.ResouceExhausted based on #5182