-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to containerd 2 #5507
base: master
Are you sure you want to change the base?
Upgrade to containerd 2 #5507
Conversation
a1ee378
to
11d49af
Compare
11d49af
to
76ece75
Compare
46749b9
to
bb97ba6
Compare
14b9621
to
ae13fa9
Compare
f20a6d7
to
6aef995
Compare
Current status:
I'm currently trying to understand where I need to pass
|
6aef995
to
129a7c4
Compare
a1417b2
to
3714e61
Compare
3714e61
to
488ed59
Compare
We should figure out why the test is failing but I also think its time to roadmap removal of the schema1 support. Especially for build use cases, there shouldn't be a need to build from such old images as a base. If so, explicit conversion may not be so bad if some users still require. |
One last failing test is related to the way how rootless tests are set up. See #4630 (comment) for discussion. |
a6e0281
to
0905473
Compare
0905473
to
80f0992
Compare
Signed-off-by: Marat Radchenko <[email protected]>
80f0992
to
e2d998b
Compare
Schema v1 support will be removed in containerd-2.1. While we continue to support it when containerd is launches with CONTAINERD_ENABLE_DEPRECATED_PULL_SCHEMA_1_IMAGE=1 env variable, the effort to keep the test working isn't worth it. Signed-off-by: Marat Radchenko <[email protected]>
e2d998b
to
6698381
Compare
This PR depends on
Non-import changes:
ExpiresIn
was changed toExpiresInSeconds
inauthprovider.go
overlay_linux.go
main_containerd_worker_windows.go
testUndeclaredArg
indockerfile_lint_test.go
testSchema1Image
test. It is very nontrivial to pushCONTAINERD_ENABLE_DEPRECATED_PULL_SCHEMA_1_IMAGE=1
env variable from a single place to both rootful and rootless tests (if you know such place, tell me!). Schema v1 is going away in containerd 2.1 anyway. buildkit still supports in currently. If this change is unacceptable... Well, need more time to find where exactly to putCONTAINERD_ENABLE_DEPRECATED_PULL_SCHEMA_1_IMAGE=1
in buildkit test framework.Closes #4630
Closes #5514