Fix fetching of tag objects #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we tried to fetch each Git target to a local Git branch. That works for PRs, branches and plain tags, but not for tag objects. Those can only be stored in local tags. Now, we fetch everything to a local tag first, and then copy just the commit to the branch. Also, added debug-level logging for child process output. This is useful to see why the unit-tests are failing. Signed-off-by: Thomas Leonard <[email protected]>
talex5
force-pushed
the
fetch-tag-objects
branch
from
5e3209f
to
79c2f72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we tried to fetch each Git target to a local Git branch. That
works for PRs, branches and plain tags, but not for tag objects. Those
can only be stored in local tags.
Now, we fetch everything to a local tag first, and then copy just the
commit to the branch.
Also, added debug-level logging for child process output. This is useful
to see why the unit-tests are failing.
Fixes #415.