github: don't ignore errors from DataKit #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Leonard <[email protected]>
talex5
force-pushed
the
log-errors
branch
2 times, most recently
from
862966a
to
0d4325c
Compare
samoht
approved these changes
Apr 5, 2017
Lots of these functions used to ignore errors silently. This can lead to bugs in the users of the library (e.g. we lost our 9p connection but we think instead that the file we wanted doesn't exist). For now, I've converted it to log errors in these cases but continue with the old behaviour. Assuming we don't see these errors being logged, we can change the code to raise exceptions instead. Also, updated the client to report "Can't walk from a file" as `Not_dir. Signed-off-by: Thomas Leonard <[email protected]>
talex5
pushed a commit
to talex5/datakit
that referenced
this pull request
Apr 20, 2017
If we can't do the operation requested, we should fail and let the caller know. Continues PR moby#513. Signed-off-by: Thomas Leonard <[email protected]>
talex5
pushed a commit
to talex5/datakit
that referenced
this pull request
Apr 20, 2017
If we can't do the operation requested, we should fail and let the caller know. Continues PR moby#513. Signed-off-by: Thomas Leonard <[email protected]>
talex5
pushed a commit
to talex5/datakit
that referenced
this pull request
Apr 20, 2017
If we can't do the operation requested, we should fail and let the caller know. Continues PR moby#513. Signed-off-by: Thomas Leonard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of these functions used to ignore errors silently. This can lead
to bugs in the users of the library (e.g. we lost our 9p connection but
we think instead that the file we wanted doesn't exist). For now, I've
converted it to log errors in these cases but continue with the old
behaviour. Assuming we don't see these errors being logged, we can
change the code to raise exceptions instead.