Add support for nftables #2605
Open
Add support for nftables #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
marked this pull request as draft
|
thanks for your contribution @evol262, adding the interfaces for the iptble layer will make it simpler to extend the codebase and the nftable implementation will improve the speed of programming the network rules. |
added 4 commits
January 21, 2021 19:13
With the release of EL8, nftables has become the default firewall
implementation on minimal installs of CentOS/OEL/RHEL8. While an
iptables driver is available (both in libnetwork and a mapper in
nftables itself), this is not guaranteed to be present. firewalld
pulls in iptables, but firewalld itself does not yet support raw
commands to nftables.
iptables calls were heavily enmeshed in libnetwork. It was
necessary to create a relatively large interface in order to
break the coupling to native iptables implementations, but this
offers the flexibility to support or add other drivers in the
future
Remaining changes are needed to:
drivers/bridge/link.go
drivers/bridge/setup_tables.go
drivers/overlay/encryption.go
drivers/overlay/filter.go
resolver_unix.go
service_linux.go
But all are sall in scope compared to this, and are translating
remaining raw iptables rules to nftables and adding additional
interface methods/methods for re-used logic
Signed-off-by: Ryan Barry <[email protected]>
nftables does not yet seem to support marking mangled packets using the same mechanism as iptables for encrypted vxlan, but this is a relatively isolated use case outside of explicit enablement in swarm Add a few more methods to the firewall interface to support per-interface forwarding and rules. Add convenience rules for drop/accept (nftables does not have a "-j DROP|ACCEPT" mechanism, so the mechanics need to be slightly different) to keep purging implementation-specific code from the drivers Signed-off-by: Ryan Barry <[email protected]>
Only remanining are resolver and setup_tables Signed-off-by: Ryan Barry <[email protected]>
Signed-off-by: Ryan Barry <[email protected]>
ghost
marked this pull request as ready for review
|
Hi! Very interesting in nftables support... any updates on reviewing this PR? |
|
Note we have migrated this codebase over to github.com/moby/moby/libnetwork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the release of EL8, nftables has become the default firewall
implementation on minimal installs of CentOS/OEL/RHEL8. While an
iptables driver is available (both in libnetwork and a mapper in
nftables itself), this is not guaranteed to be present. firewalld
pulls in iptables, but firewalld itself does not yet support raw
commands to nftables.
iptables calls were heavily enmeshed in libnetwork. It was
necessary to create a relatively large interface in order to
break the coupling to native iptables implementations, but this
offers the flexibility to support or add other drivers in the
future
Remaining changes are needed to:
But all are sall in scope compared to this, and are translating
remaining raw iptables rules to nftables and adding additional
interface methods/methods for re-used logic