Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vim] Be case insensitive for D in dockerfile #37235

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

kunaltyagi
Copy link
Contributor

- What I did and How I did it
Set the regex to accept d and D

- Description for the changelog
Allow vim to be case insensitive for D in dockerfile

- A picture of a cute animal (not mandatory but encouraged)
🐕

@GordonTheTurtle GordonTheTurtle added dco/no Automatically set by a bot when one of the commits lacks proper signature status/0-triage labels Jun 8, 2018
@thaJeztah
Copy link
Member

Thanks! Changes look good to me, but can you sign-off and amend your commit? See the instructions above, but let me know if you need a hand

@GordonTheTurtle GordonTheTurtle removed the dco/no Automatically set by a bot when one of the commits lacks proper signature label Jun 8, 2018
@kunaltyagi
Copy link
Contributor Author

Added signoff line

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM, thanks!

@thaJeztah
Copy link
Member

ping @vdemeester PTAL

@codecov
Copy link

codecov bot commented Jun 8, 2018

Codecov Report

Merging #37235 into master will increase coverage by 0.27%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #37235      +/-   ##
==========================================
+ Coverage   34.66%   34.93%   +0.27%     
==========================================
  Files         609      609              
  Lines       44984    44984              
==========================================
+ Hits        15594    15717     +123     
+ Misses      27304    27143     -161     
- Partials     2086     2124      +38

@moby moby deleted a comment from GordonTheTurtle Jun 8, 2018
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@vdemeester vdemeester merged commit fe3d023 into moby:master Jun 8, 2018
@kunaltyagi kunaltyagi deleted the vim-filename branch June 14, 2018 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants