-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vim] Be case insensitive for D in dockerfile #37235
Conversation
Thanks! Changes look good to me, but can you sign-off and amend your commit? See the instructions above, but let me know if you need a hand |
Signed-off-by: Kunal Tyagi <[email protected]>
Added signoff line |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, LGTM, thanks!
ping @vdemeester PTAL |
Codecov Report
@@ Coverage Diff @@
## master #37235 +/- ##
==========================================
+ Coverage 34.66% 34.93% +0.27%
==========================================
Files 609 609
Lines 44984 44984
==========================================
+ Hits 15594 15717 +123
+ Misses 27304 27143 -161
- Partials 2086 2124 +38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐯
- What I did and How I did it
Set the regex to accept d and D
- Description for the changelog
Allow vim to be case insensitive for D in dockerfile
- A picture of a cute animal (not mandatory but encouraged)
🐕