Test if error is nil before to log it #2720
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: nmengin [email protected]
- What I did
This PR adds a test on the error sent by the function
store.CreateNetwork()
when a manager becomes leader in the way to avoid the creation of an error message for a error which isnil
.- How I did it
The
if
statement test if the error is not nil before to log a message.- How to test it
Start a swarmkit cluster with a log level >=
logLevel.Error
.Thanks to the modification the errors described below sould not appear:
- Description for the changelog
Delete the error logs generated when prefefined networks are initiliazed successfully, Fixes #2719 .