Skip to content

Commit

Permalink
Update CI config files to use Node-12.x (#3919)
Browse files Browse the repository at this point in the history
* ci(.travis.yml): Update Travis config to use Node-12

Downgrade to Node-10 for browser tests so we can use the pre-built canvas package.

* ci(appveyor.yml): Update AppVeyor config to use Node-12

Future-proof install for Node versions to use alternative Node update method if pre-installed version unavailable.
  • Loading branch information
plroebuck authored Jun 12, 2019
1 parent 3064d25 commit e341ea4
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 3 deletions.
5 changes: 4 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@ stages:

# defaults
language: node_js
node_js: '11'
node_js: '12'
addons:
apt:
packages:
# Growl
- libnotify-bin
# `nvm install` happens before the cache is restored, which means
# we must install our own npm elsewhere (`~/npm`)
Expand Down Expand Up @@ -49,6 +50,8 @@ jobs:
node_js: '6'

- script: npm start test.bundle test.browser
# XXX: update when canvas supplies a prebuilt binary for Node.js v12.x
node_js: 10
install: npm ci # we need the native modules here
addons:
artifacts:
Expand Down
11 changes: 9 additions & 2 deletions appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ shallow_clone: true
clone_depth: 1
environment:
matrix:
- nodejs_version: '11'
- nodejs_version: '12'
- nodejs_version: '10'
- nodejs_version: '8'
- nodejs_version: '6'
Expand All @@ -35,7 +35,14 @@ install:
## Node-related installs
- ps: Add-AppveyorMessage "Installing Node..."
- set PATH=%APPDATA%\npm;C:\MinGW\bin;%PATH%
- ps: Install-Product node $env:nodejs_version x64
## Prefer pre-installed Node versions, with fallback to manual update
- ps: |
try {
Install-Product node $env:nodejs_version $env:platform
} catch {
Add-AppveyorMessage " install failed - attempting manual update..."
Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version) $env:platform
}
- ps: Add-AppveyorMessage "Installing npm..."
- npm install -g npm
## Mocha-related package installs
Expand Down

0 comments on commit e341ea4

Please sign in to comment.