Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The growl code in _mocha is dead code #2132

Closed
julienw opened this issue Feb 28, 2016 · 2 comments
Closed

The growl code in _mocha is dead code #2132

julienw opened this issue Feb 28, 2016 · 2 comments

Comments

@julienw
Copy link
Contributor

julienw commented Feb 28, 2016

The code in

mocha/bin/_mocha

Lines 435 to 451 in 9c41051

function growl(runner, reporter) {
var notify = require('growl');
runner.on('end', function(){
var stats = reporter.stats;
if (stats.failures) {
var msg = stats.failures + ' of ' + runner.total + ' tests failed';
notify(msg, { name: 'mocha', title: 'Failed', image: images.fail });
} else {
notify(stats.passes + ' tests passed in ' + stats.duration + 'ms', {
name: 'mocha'
, title: 'Passed'
, image: images.pass
});
}
});
}
is not used anywhere anymore.

@julienw julienw changed the title The growl code is _mocha is dead code The growl code in _mocha is dead code Mar 5, 2016
@danielstjules
Copy link
Contributor

You're right! Welcome a PR that deletes it :)

julienw added a commit to julienw/mocha that referenced this issue Mar 12, 2016
The growl functionality lives in core mocha now.
@julienw
Copy link
Contributor Author

julienw commented Mar 12, 2016

OK, that one was easy ;)

danielstjules added a commit that referenced this issue Mar 21, 2016
Remove dead growl code in bin/_mocha (fixes #2132)
plroebuck added a commit to plroebuck/mocha that referenced this issue Apr 21, 2018
Issue mochajs#2132 removed the unused growl() function, but left the images. This finishes the job.

Fixes mochajs#3341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants