-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate shell scripts from Mocha's test suite #2805
Comments
Relevant to migrating away from shellscripts for test: https://gitter.im/unexpectedjs/unexpected?at=5919695c2b926f8a6757de02 |
Move linting into an npm script. Relates to #2805
At present, the following three shell scripts remain: test/acceptance/glob/glob.sh If glob.sh is indeed a valid exception, then this issue can be closed, as #2807 has landed in master, and has been released in v3.4.2 |
To clarify, the parenthetical about CI scripts was referring to those Travis scripts, and glob.sh was not proposed as an exception but as an example of the sort of scripts the issue is about -- required for Mocha's complete test suite to be run yet themselves requiring a Posix shell and/or environment (both in this case). |
The travis scripts are fine. They are never required for local execution. We need to convert the glob script and also get rid of the makefile |
Move linting into an npm script. Relates to mochajs#2805
Besides getting ourselves off the Makefile (#2268?), the other thing that doesn't work on a default Windows development environment is Unix/Linux shell scripts. (Even with a Posixy environment, they can have problems with line endings like #2801; this would not be an issue if they weren't Posixy shell scripts in the first place.) As far as I am aware, Node's
child_process
actions can run anything in a shell the same as if it were in a.sh
script, so we should be able to convert any such test files to proper JS test files.The one of these of which I am aware is:
(We can make an exception for scripts used only by CI and not local test runs, of course.)
The text was updated successfully, but these errors were encountered: