Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better test harness for reporters #3260

Closed
boneskull opened this issue Mar 1, 2018 · 2 comments
Closed

better test harness for reporters #3260

boneskull opened this issue Mar 1, 2018 · 2 comments
Labels
good first issue new contributors should look here! status: accepting prs Mocha can use your help with this one! type: cleanup a refactor

Comments

@boneskull
Copy link
Contributor

There's a lot of duplicated code in the reporter tests. Let's extract that into helper modules/functions/etc.

@boneskull boneskull added status: accepting prs Mocha can use your help with this one! good first issue new contributors should look here! type: cleanup a refactor labels Mar 1, 2018
@jmuzsik
Copy link

jmuzsik commented Mar 3, 2018

Hi! I'd be willing to do this. I mean, do people get assigned in this repo or is it just a race to finish the issue. First come, first serve?

@Bamieh
Copy link
Contributor

Bamieh commented Mar 7, 2018

@jmuzsik Hello!, thanks for your interest to contribute 🎉. Just say you're going to work on it and start. Here is how it generally works in all OSS; You fork the project and create a new branch from master with a link to the issue number you are working as a commit message and push it before writing any code. This will link your branch to this issue, letting people know that you are working on it and follow on the progress.

example:

$ git commit -am "Closes https://github.com/mochajs/mocha/issues/3260"

If you need comments on the code or your branch is ready, submit a PR and we'll have a look at it to get it merged!

Cheers

sgilroy pushed a commit to TwineHealth/mocha that referenced this issue Feb 27, 2019
* Closes mochajs#3260

* refactor-better test harness for reporters tests'

* refactor-better test harness for reporters tests'

* refactor - some additional work

* refactor - helper func

* refactor - helper func

* refactor - helper func

* fix - improvements to helper functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue new contributors should look here! status: accepting prs Mocha can use your help with this one! type: cleanup a refactor
Projects
None yet
Development

No branches or pull requests

3 participants