Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache growl on appveyor #4390

Closed
boneskull opened this issue Jul 30, 2020 · 0 comments · Fixed by #4402
Closed

cache growl on appveyor #4390

boneskull opened this issue Jul 30, 2020 · 0 comments · Fixed by #4402
Labels
area: windows Windows-specific good first issue new contributors should look here! status: accepting prs Mocha can use your help with this one! type: chore generally involving deps, tooling, configuration, etc.

Comments

@boneskull
Copy link
Contributor

To run growl-related tests on windows, we install growl:

  ## Manual Growl install
  - ps: Add-AppveyorMessage "Installing Growl..."
  - ps: $seaURL = "https://github.com/briandunnington/growl-for-windows/releases/download/final/GrowlInstaller.exe"
  - ps: $seaPath = "$($env:USERPROFILE)\GrowlInstaller.exe"
  - ps: $webclient = New-Object Net.WebClient
  - ps: $webclient.DownloadFile($seaURL, $seaPath)

I think github's rate-limiter may not appreciate this sort of thing, and occasionally the download will fail. We shouldn't need to download this installer on every build; we can cache the installer, and only download if it is not present in the cache.

I'd do this myself, but I don't know enough (read: any) PowerShell to skip the download step if the file exists, and I don't know if the cached files are loaded before this build step (but it seems like they should be).

So, hopefully someone who knows a bit of PS can help us out. The $seaPath value is what we want to cache, and here's the relevant AppVeyor documentation.

@boneskull boneskull added status: accepting prs Mocha can use your help with this one! type: chore generally involving deps, tooling, configuration, etc. area: windows Windows-specific good first issue new contributors should look here! labels Jul 30, 2020
refack added a commit to refack/mocha that referenced this issue Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: windows Windows-specific good first issue new contributors should look here! status: accepting prs Mocha can use your help with this one! type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
1 participant