Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Runner signature #4861

Merged
merged 1 commit into from
Apr 1, 2022
Merged

Remove deprecated Runner signature #4861

merged 1 commit into from
Apr 1, 2022

Conversation

juergba
Copy link
Contributor

@juergba juergba commented Mar 30, 2022

Description

In Mocha v9.0.0 the Runner constructor signature Runner(suite: Suite, delay: boolean) has been deprecated, see #4646.

Description of the Change

We remove mentioned Runner(suite: Suite, delay: boolean).

Instead use an option object: Runner(suite: Suite, {delay: boolean}).

@juergba juergba added semver-major implementation requires increase of "major" version number; "breaking changes" type: cleanup a refactor labels Mar 30, 2022
@juergba juergba added this to the v10.0.0 milestone Mar 30, 2022
@juergba juergba self-assigned this Mar 30, 2022
@juergba juergba merged commit b7b849b into master Apr 1, 2022
@juergba juergba deleted the juergba/runner branch April 1, 2022 06:52
This was referenced Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-major implementation requires increase of "major" version number; "breaking changes" type: cleanup a refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant