-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump chokidar #5142
Comments
Heya thanks for filing! I just marked #5114 as accepting PRs, so let's go with that one instead. That way we don't have to do raise the minimum version of |
I don't know why updating chokidar would be considered a breaking change. It's a direct dependency and not a peer dependency so mocha is free to use whatever version without compatibility issues with any other library. Also chokidar seems to be following semver and is so widely used that I doubt any breaking change makes it into a minor/patch release |
If users happen to have their own dependency on +1 to your point that it doesn't seem very likely to be a real breaking change 😄. But figuring out whether |
Bug Report Checklist
faq
label, but none matched my issue.Expected
works with typescript
Actual
chokidar is incompatible to current @types/node releases
paulmillr/chokidar#1299
Minimal, Reproducible Example
Versions
mocha 10.4.0
@types/node 20.12.11
node 20.12.2
Additional Info
If #5114 was already done this wouldn't be an issue.
I'd just bump chokidar to ^3.6.0
The text was updated successfully, but these errors were encountered: