Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover Browser Tests (and all Node versions) #2886

Closed
wants to merge 5 commits into from
Closed

Cover Browser Tests (and all Node versions) #2886

wants to merge 5 commits into from

Commits on Aug 2, 2017

  1. Find out what happens if every job posts to Coveralls; rationale: Cov… 

    …eralls typically uses the Job ID, not the Build ID, so presumably it is designed to handle multiple jobs in the same build?
    @ScottFreeCode
    ScottFreeCode committed Aug 2, 2017
    Configuration menu
    Copy the full SHA
    7dbc5a1 View commit details
    Browse the repository at this point in the history

  2. Instrumented code will run slower 

    200 ms timeout was already causing flakes even before the coverage additions anyway; testing suggests that specific tests won't pass with instrumentation without increased time.
    @ScottFreeCode
    ScottFreeCode committed Aug 2, 2017
    Configuration menu
    Copy the full SHA
    3cb7a28 View commit details
    Browse the repository at this point in the history

  3. Add browser coverage

    @ScottFreeCode
    ScottFreeCode committed Aug 2, 2017
    Configuration menu
    Copy the full SHA
    fea20c5 View commit details
    Browse the repository at this point in the history

  4. Try using the same instrumentation as NYC from the Node tests

    @ScottFreeCode
    ScottFreeCode committed Aug 2, 2017
    Configuration menu
    Copy the full SHA
    afd632a View commit details
    Browse the repository at this point in the history

  5. Try using browser tests as integration testing for browser-entry.js… 

    … by covering it in the `BUILDTMP/mocha.js` bundle
    @ScottFreeCode
    ScottFreeCode committed Aug 2, 2017
    Configuration menu
    Copy the full SHA
    d3aab5f View commit details
    Browse the repository at this point in the history