Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore difference of newline output in diffing test #2920

Merged
merged 1 commit into from
Dec 12, 2017
Merged

Ignore difference of newline output in diffing test #2920

merged 1 commit into from
Dec 12, 2017

Conversation

ScottFreeCode
Copy link
Contributor

Fixes #2801 the brute-force but simple and easy way without refactoring the test design.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.973% when pulling 42fbf7e on ignore-newline-diffs-in-test into 958fbb4 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.017% when pulling 50249a2 on ignore-newline-diffs-in-test into 075bd51 on master.

@ScottFreeCode
Copy link
Contributor Author

CI for this is green after a rebase.

@boneskull boneskull merged commit f7d6d8b into master Dec 12, 2017
@boneskull boneskull deleted the ignore-newline-diffs-in-test branch December 12, 2017 04:48
@boneskull boneskull added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Dec 29, 2017
@boneskull boneskull added this to the v4.1.0 milestone Dec 29, 2017
@boneskull boneskull added qa and removed qa labels Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boneskull boneskull Awaiting requested review from boneskull

@dasilvacontin dasilvacontin Awaiting requested review from dasilvacontin

Assignees
No one assigned
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Milestone
v4.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ScottFreeCode @coveralls @boneskull