Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not recursively call process.exit() #3684

Merged
merged 2 commits into from
Jan 23, 2019

Commits on Jan 23, 2019

  1. do not recursively call process.exit()

    When inside `process.on('exit')`, calling `process.exit()`
    stops other `exit` event listeners from being invoked.
    
    This has lead to issues with coverage generation with `nyc`
    because a fallback exit detection mechanism in it that relies
    on internal Node.js APIs was accidentally disabled in Node v11.7.0,
    leaving `nyc` with no way to detect process exit.
    
    Refs: nodejs/node#25650
    addaleax committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    3a03704 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    062f519 View commit details
    Browse the repository at this point in the history