Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop node.js v8 support #4164

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Drop node.js v8 support #4164

merged 1 commit into from
Mar 12, 2020

Conversation

UlisesGascon
Copy link
Contributor

Description of the Change

I removed support to v8 in CI and documentation as explained in #4163

Alternate Designs

N/A

Why should this be in core?

Bump minimum Nodejs version

Benefits

No need to worry about support for Node v8

Possible Drawbacks

N/A

Applicable issues

Close #4163

@coveralls
Copy link

coveralls commented Jan 22, 2020

Coverage Status

Coverage increased (+0.07%) to 92.925% when pulling 4a53713 on UlisesGascon:issue/4163 into 883ae4b on mochajs:master.

Copy link
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also adapt our linting rules in "mocha/.eslintrc.yml":
replace ecmaVersion: 2017 by ecmaVersion: 2018

.travis.yml Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
@juergba juergba added area: node.js command-line-or-Node.js-specific semver-major implementation requires increase of "major" version number; "breaking changes" labels Jan 28, 2020
@juergba juergba added this to the v8.0.0 milestone Jan 28, 2020
UlisesGascon added a commit to UlisesGascon/mocha that referenced this pull request Feb 2, 2020
Copy link
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase, we made some changes to ".eslintrc.yml".

.eslintrc.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
UlisesGascon added a commit to UlisesGascon/mocha that referenced this pull request Feb 2, 2020
Copy link
Contributor

@juergba juergba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@UlisesGascon thank you
We will wait with merging this PR to master, Mocha is not yet ready for the next major release.

@tripu
Copy link
Contributor

tripu commented Jun 11, 2020

(You're everywhere, @UlisesGascon! :)

georgeOsdDev pushed a commit to mobilusoss/textlint-browser-runner that referenced this pull request Jun 15, 2020
cscott added a commit to cscott/seek-bzip that referenced this pull request Jul 31, 2020
Because of the bump in mocha version to 8.0, we can no longer run tests
on Node.js v8.x and below: mochajs/mocha#4164

The fibers package at version 5.0 also doesn't support Node.js v10.x
or lower, although it seems to work fine in my limited testing.
cscott added a commit to cscott/seek-bzip that referenced this pull request Jul 31, 2020
Because of the bump in mocha version to 8.0, we can no longer run tests
on Node.js v8.x and below: mochajs/mocha#4164

The fibers package at version 5.0 also doesn't support Node.js v10.x
or lower, although it seems to work fine in my limited testing.

The commander package requires node 6 or greater:
tj/commander.js#1053
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: node.js command-line-or-Node.js-specific semver-major implementation requires increase of "major" version number; "breaking changes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Node.js 8.x support
4 participants