Fix: 'karma-mocha' should run both browser bundles #4663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juergba
added
the
semver-patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some days ago I added a second browser bundle to our package:
mocha.jstranspiled to ES5mocha-es2018.jswithout transpilationWhen customizing our browser tests I ended up with executing the karma tests twice, using the same bundle
mocha.js. So the newmocha-es2018currently remains untested.Description of the Change
I could not find a way to convince karma-mocha to run a browser bundle other than named
mocha.js.Therefore I rename the two bundles accordingly before launching karma.