-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: eleventy template builds crash with 'unexpected token at ": string, msg..."' #5116
Merged
JoshuaKGoldberg
merged 1 commit into
mochajs:master
from
LcsK:fix/eleventy/problem-writing-eleventy-templates
Mar 8, 2024
Merged
fix: eleventy template builds crash with 'unexpected token at ": string, msg..."' #5116
JoshuaKGoldberg
merged 1 commit into
mochajs:master
from
LcsK:fix/eleventy/problem-writing-eleventy-templates
Mar 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eleventy wasn't being able to parse the JSDocs for the returned type on the getFullErrorStack function. Defining it as a new type and then referencing it on the function fixes the issue
The committers listed above are authorized under a signed CLA. |
JoshuaKGoldberg
changed the title
Fix: Eleventy template builds crash with 'unexpected token at ": string, msg..."'
fix: eleventy template builds crash with 'unexpected token at ": string, msg..."'
Mar 7, 2024
JoshuaKGoldberg
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 thanks!
3 tasks
This was referenced Jul 16, 2024
This was referenced Nov 1, 2024
This was referenced Nov 1, 2024
This was referenced Nov 9, 2024
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prs
Overview
Eleventy wasn't being able to parse the JSDocs for the returned type on the getFullErrorStack function. Defining it as a new type and then referencing it on the function fixes the issue.
Running
npm run docs
on this branch should work now.