Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing call chaining for before*, after*, it.only, and describe.only #840

Closed
wants to merge 1 commit into from
Closed

Fixing call chaining for before*, after*, it.only, and describe.only #840

wants to merge 1 commit into from

Conversation

nbrownus
Copy link

@nbrownus nbrownus commented May 9, 2013

For BDD style test suites you could not do .timeout() or anything else after any of these functions. This fixes that, especially important for it.only().

@tj
Copy link
Contributor

tj commented May 22, 2013

why not do this.timeout(n) in the test case etc?

@nbrownus
Copy link
Author

Main reason for this patch is that describe and it allow chaining making it odd that not everything follows that convention. It is more of an issue when using .only since there may already be other calls chained and not having this patch results in an error on the definition of the suite or test.

@travisjeffery
Copy link
Contributor

Fixed it.only, describe.only. I don't see the point of before, after.

travisjeffery added a commit that referenced this pull request Sep 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants