Minimize calls to gen_tcp:send() to optimize performance. #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate a 50 to 1 performance improvement with this change.
etrepum
added a commit
that referenced
this pull request
Sep 29, 2014
Minimize calls to gen_tcp:send() to optimize performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Bob,
It's Jeremy again. Here's the commit I wrote you about. If you wouldn't mind, make sure I didn't screw something up.
The unit tests with the word "hundred" in them indicate a 50 to 1 performance improvement with this change. The tests previously took 4.03 seconds to run and are now taking 0.08 seconds. That sounds way too good to be true. In the context of our system, we saw more like a 1.5% performance improvement.
Jeremy