Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send connection close header when Expect header is in request #156

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

InoMurko
Copy link

@InoMurko InoMurko commented Apr 4, 2015

Based on http://www.w3.org/Protocols/rfc2616/rfc2616-sec8.html#sec8.2.3 server should not respond with a header Connection: close.

@etrepum
Copy link
Member

etrepum commented Apr 4, 2015

I'm not entirely sure this is correct as it may also prevent the connection from being closed with http 1.0 and possibly other scenarios when it should close. Tests to demonstrate that this does what it's supposed to would be fantastic.

@InoMurko
Copy link
Author

InoMurko commented Apr 4, 2015

Well I guess it is not a matter of right and wrong but I've experienced weird behaviour from webdav clients when this header was present.

Apache mod_dav is sending only 100 Continue, for example.

@etrepum
Copy link
Member

etrepum commented Apr 4, 2015

Yes, I can certainly see how there might be a situation where it may be difficult to write correct code with the current behavior. Without tests, it's hard to demonstrate that this is sufficient to fix the problem you're having, and that it doesn't cause other sorts of regressions along the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants