Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebar3 improvements #243

Merged
merged 3 commits into from
May 10, 2022
Merged

Rebar3 improvements #243

merged 3 commits into from
May 10, 2022

Conversation

nickva
Copy link
Collaborator

@nickva nickva commented May 9, 2022

A few improvements:

  • Replace template app with an example project.
  • Remove rebar executable.
  • Simplify the Makefile.
  • Use official OTP images for CI. They seem to be pretty recent and already have rebar built-in.

nickva added 3 commits May 9, 2022 16:58
Since rebar3 expects templates to be in `~/.config/rebar3/templates/` [1], opt
to instead having just an example project users can copy and update on their
own.

[1] https://www.rebar3.org/docs/tutorials/templates
Remove `app` file and allow specifying a different REBAR executable
so we can test both rebar2 and rebar3.

Since OTP team provides docker images we can use those for CI. They seem to be
a bit more recent than ESL packages and also provide `rebar` and `rebar3`
commands.
Copy link
Member

@etrepum etrepum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@etrepum etrepum merged commit a55c1ec into mochi:rebar3 May 10, 2022
@nickva nickva deleted the rebar3-improvements branch May 10, 2022 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants