-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Erlang CI images #261
Conversation
nickva
commented
Sep 22, 2023
- Use latest patch levels for 24 and 25.
- Add 26 to the list.
Seeing
From https://www.erlang.org/blog/otp-26-highlights/#ssl-safer-defaults |
ba907b1
to
78d4c29
Compare
Trying to pass
Could be an issue with the how the certificate was generated (has is old signature algorithm). Looking at included server cert with
|
* Use latest patch levels for 24 and 25. * Add 26 to the list. In Erlang 26 TLS `verify` option switched the default value from `verify_none` to `verify_peer` [1]. So had to explictly set it in the test client. [1] https://www.erlang.org/blog/otp-26-highlights/#ssl-safer-defaults
674a200
to
293b95d
Compare
The updated certificate with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a script that generates a new self-signed cert which appears to work and will be good for whoever looks at this next so they can see how they were generated. I did get a test failure once but I can't reproduce it locally and it didn't reproduce when I restarted the build 🤷🏻♂️
Thank you. That worked. I also noticed the failure afterwards, but It seemed like an unrelated flaky test. |